Printing exact error for clean file.

[saurabhshri]

Removes ambiguity as of why unable to open clean file. Gives better aid in resolving the issue.

Example : I have attached a console log below of 4 different runs. fopenerror.txt

1. cf -output.txt

shouldn't work because I am working in directory which requires admin rights to create new files. Only displays : ###MESSAGE#Unable to open clean file: output.txt

2. -cf /out/output.txt

same as above.

3. -cf d:/out/output.txt

Directory d:/ doesn't require any admin right, but "out" doesn't exist. So again, only displays : ###MESSAGE#Unable to open clean file: output.txt

4. -cf d:/output.txt

Works, because d:/ is both writable and exists.

[cfsmp3]

This is a good idea, but instead of using perror() use print_error() -as in the line above-. You can get the text from sterror (). Problem with perror() is that it always uses stderr which may be closed, or the user may have requested -quiet mode, etc.

[saurabhshri]

@cfsmp3 Thank you! :)

I used perror() because when fopen returns with an error, it sets the variable errno with some number which contains the exact message (like permission denies etc.). But I see the problem.

print_error(CCX_COMMON_EXIT_FILE_CREATION_FAILED, "Unable to open clean file: %s\n", cfg->out_elementarystream_filename);
perror("Details : ");

Shall I replace it with :

print_error(CCX_COMMON_EXIT_FILE_CREATION_FAILED, "Unable to open clean file: %s \n. Details : %s \n", cfg->out_elementarystream_filename,strerror(errno));

[cfsmp3]

You can use two print_error lines for clarity, but that's OK. Just try it though - try writing to a non existing directory to confirm you get the text explanation.

…

On Tue, Dec 13, 2016 at 10:59 PM, Saurabh Shrivastava < ***@***.***> wrote: @cfsmp3 <https://github.com/cfsmp3> Thank you! :) I used perror() because when fopen returns with an error, it sets the variable errno with some number which contains the exact message (like permission denies etc.). But I see the problem. print_error(CCX_COMMON_EXIT_FILE_CREATION_FAILED, "Unable to open clean file: %s\n", cfg->out_elementarystream_filename); perror("Details : "); Shall I replace it with : print_error(CCX_COMMON_EXIT_FILE_CREATION_FAILED, "Unable to open clean file: %s \n. Details : %s \n", cfg->out_elementarystream_ filename,strerror(errno)); — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#529 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFrJ2QH17x9DVLYbZCOJXV31nRi74_xiks5rH5O_gaJpZM4LLg0k> .

[saurabhshri]

@cfsmp3 I tried and it worked. :)

Now, I have formatted the output to remove that 'space' and '.' before 'Deatils'

It will now appear as :

saurabh@ubuntu:~/Desktop/cc/ccextractor-patch-7/linux$ ./ccextractor test.ts -autoprogram  -out=srt -bom -cf /out/output.txt -latin1
###MESSAGE#Unable to open clean file: /out/output.txt
Details : No such file or directory.

If it looks good to you, shall I send a PR?

EDIT:

Not using two print_error lines because if we supply mode (CCX_COMMON_EXIT_FILE_CREATION_FAILED), it displays :

###MESSAGE#Unable to open clean file: /out/output.txt

###MESSAGE#Details : No such file or directory .

and if we don't, i.e. mode (0), it displays :

###MESSAGE#Unable to open clean file: /out/output.txt

Error : Details : No such file or directory .

I think the 'single line' implementation produces cleaner result and also, the function is only called once. :)

[saurabhshri]

@cfsmp3 Thanks :)