Formatted header files (GCI) #531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canihavesomecoffee
requested changes
Dec 14, 2016
src/lib_ccx/ccx_decoders_common.h
Outdated
| int do_cb (struct lib_cc_decode *ctx, unsigned char *cc_block, struct cc_subtitle *sub); | ||
| void printdata (struct lib_cc_decode *ctx, const unsigned char *data1, int length1, | ||
| const unsigned char *data2, int length2, struct cc_subtitle *sub); | ||
| const unsigned char *data2, int length2, struct cc_subtitle *sub); |
Member
There was a problem hiding this comment.
This makes it less readable
src/lib_ccx/ccx_decoders_structs.h
Outdated
| unsigned char *data[2]; | ||
| int linesize[2]; | ||
| #ifdef ENABLE_OCR | ||
| #ifdef ENABLE_OCR |
Member
There was a problem hiding this comment.
Ifdef's are supposed to be on that level of indentation
src/lib_ccx/ccx_demuxer.h
Outdated
| unsigned dvb_sub_pid[SUB_STREAMS_CNT]; | ||
| unsigned tlt_sub_pid[SUB_STREAMS_CNT]; | ||
| unsigned mp4_cc_track_cnt; | ||
| unsigned program_cnt; |
Member
There was a problem hiding this comment.
This makes it less legible.
Contributor
|
Too many files affected and formatting doesn't really improve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.