Improved comment indentation #559
Conversation
canihavesomecoffee
left a comment
canihavesomecoffee
left a comment
There was a problem hiding this comment.
Some good parts, some improvements needed
| int currDecodeStreamPTS; // Time of the data returned by the function | ||
| int prevDecodeStreamPTS; // Previous time | ||
| int VideoStreamMS; // See ableve, just for video | ||
| int CaptionStreamStyle; // 1 = NTSC, 2 = ATSC |
There was a problem hiding this comment.
This alignment is good.
| #define DVRMS_ATSC "\x89\x8A\x8B\xB8\x49\xB0\x80\x4C\xAD\xCF\x58\x98\x98\x5E\x22\xC1" | ||
|
|
||
| // 10.13 - Undocumented DVR-MS properties | ||
| // 10.13 - Undocumented DVR-MS properties |
There was a problem hiding this comment.
Why is this aligned this way (same with the ones above?)
| { | ||
| unsigned char cc_count; | ||
| // buffer to hold cc data | ||
| // buffer to hold cc data |
There was a problem hiding this comment.
This does not add much to the readability
There was a problem hiding this comment.
That was an small code; then i prefer to go for alignment of all the cooments
|
@meets2tushar Can you submit a new PR with only the changes @canihavesomecoffee says are OK? It's a lot easier if we can merge a few things first and then deal with the rest. If there's changes that can be merged already let's take care of them already. |
|
@cfsmp3 I am not able to make another (a new ) PR. It is showing me a page of comparison only. |
|
@meets2tushar I don't understand, sorry. You can just close this PR and start a new one with the files Willem said. |
Bumps [python-magic](https://github.com/ahupp/python-magic) from 0.4.22 to 0.4.24. - [Release notes](https://github.com/ahupp/python-magic/releases) - [Changelog](https://github.com/ahupp/python-magic/blob/master/CHANGELOG) - [Commits](ahupp/python-magic@0.4.22...0.4.24) --- updated-dependencies: - dependency-name: python-magic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 participants
As a [GCI task] (https://codein.withgoogle.com/dashboard/task-instances/6400773606866944/)
improved comment section.