Memory optimization in HARDSUBX edit_distance #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrideshmg
pushed a commit
to hrideshmg/ccextractor
that referenced
this pull request
Mar 12, 2025
* update linux CI script Remove redundant tests and add rust flag for cmake build * Delete build files after tests are complete * fix binary path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made memory optimization in function edit_distance. This function is calls often in hardsubx, and works for
O(len^2)time andO(len^2)memory. But in fact we can work with two massives with size len instead of len. With my commit it works now with massive with size of 2*min(len1,len2).For example, in this two videos: https://abhinavshukla95.wordpress.com/2016/08/18/google-summer-of-code-work-product-submission/ We have maximum wasting of memory in first video 59x59 ints ans in second video 87x98 with example arguments. With my commit we can use memory of 2x59 ints and 2x87 ints respectively.