removed warnings (-Wall)

[rkuchumov]

So, I decided to remove warnings. I'll test on correct files and write whether it's OK or not.

[cfsmp3]

Don't know about some of these changes. For example:

        read_u32(esstream); // Advance bitstream
        (void) read_u32(esstream); // Advance bitstream

I think that's a "fix" to remove a warning from a braindead compiler. Is it
really complaining about the return value being discarded? If yes, I think
it's best to create skip_u32() and use it, rather than add (void)
everywhere in which we don't care about the return value.

In other places the variables are not being used because they are for
debug, but the debug lines are still there (just commented out), for
example:

            int32_t dwVersion = 0;
            int32_t unknown = 0;

I think it's better to also comment out the variable definitions than
remove everything (variables and the commented out code that used them).
After all, we know that from time to time we need to debug things again...
a sample that doesn't work, a segfault, etc, and we'd need to add the debug
code again.

In init_avc()

else
{

/* CFS: Warning!!: Untested stuff, copied from specs (8.2.1.3) */
LLONG FrameNumOffset = 0;

That code should be left there. Comment out, OK. Completely remove no. I
added it when debugging some thing and I typed the spec completely
(couldn't test). I'm sure eventually we'll find the right sample.

In xds.c, I try to parse all the fields. Some of the fields are not
displayed later to the user (which is why they may cause the compiler to
complain), but the are useful when debugging XDS. So we cannot completely
remove those.

On Thu, Jul 3, 2014 at 2:49 PM, Ruslan notifications@github.com wrote:

So, I decided to remove warnings. I'll test on correct files and write

whether it's OK or not.

You can merge this Pull Request by running

git pull https://github.com/rkuchumov/ccextractor cleanup

Or view, comment on, or merge it at:

#62
Commit Summary

• removed warnings (-Wall)

File Changes

• M src/608.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-0 (5)
• M src/608_sami.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-1 (16)
• M src/708.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-2 (2)
• M src/asf_functions.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-3 (6)
• M src/avc_functions.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-4 (41)
• M src/es_functions.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-5 (10)
• M src/es_userdata.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-6 (4)
• M src/general_loop.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-7 (8)
• M src/gpacmp4/mp4.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-8 (9)
• M src/gpacmp4/stbl_write.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-9 (2)
• M src/myth.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-10
  (17)
• M src/spupng_encoder.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-11 (2)
• M src/stream_functions.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-12 (9)
• M src/ts_tables.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-13 (4)
• M src/wtv_functions.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-14 (1)
• M src/xds.c
  https://github.com/CCExtractor/ccextractor/pull/62/files#diff-15
  (11)

Patch Links:

• https://github.com/CCExtractor/ccextractor/pull/62.patch
• https://github.com/CCExtractor/ccextractor/pull/62.diff

—
Reply to this email directly or view it on GitHub
#62.

[rkuchumov]

OK, I'll comment instead of deleting and add skip_u32().

[rkuchumov]

So, I commented instead of deleleting and removed a few variables which are just declared but not metioned anywhere. Also tested on correct files, everything seems ok.