SMPTE-TT : Removed appearance of garbage value in color code.

[saurabhshri]

Today we made Sample Platform's difference generator a little better and found out that for SMPTE-TT font color often contains garbage data.

When I added that font color support, I left color_code variable uninitialized and hence this garbage value. This hopefully fixes this.

[saurabhshri]

Preview from Sample Platform (PR Fixes the issue):

[cfsmp3]

Instead of

*color_code = NULL;
strncat(color_code,(context->subline) + (temp_pointer - (context->subline) + 1),6); //obtained color code

Just use
strncpy
which doesn't care about existing data.

Also be aware that strncat (or strncpy) don't null terminate the destination string, so you need to do it yourself.

(context->subline) + (temp_pointer - (context->subline) + 1)

That's a weird thing to do. Why not just temp_pointer+1 ?

[saurabhshri]

@cfsmp3 Earlier I too was using strncpy to implement this (here : 6c1ba95). But as you mentioned it doesn't null terminate the string, so to add it explicitly was a two steps or more( because strcat uses \0 to identify the end of string which is not present if strncpy is used).

Where else strncat does infact null terminates the string, as opposed to strncpy. This is why I used this.

And regarding (context->subline) + (temp_pointer - (context->subline) + 1), I actually used Find and Replace to replace a variabe used while debugging to (temp_pointer - (context->subline) + 1, hence this :P

I'll change it to temp_pointer+1.

Does it sound okay?

[cfsmp3]

Also do color_code[7] instead of * and then malloc... 7 bytes it's OK to get from the stack, no need to deal with dynamic alloc. You can even init that block to all 0s.