Skip to content

[Fix][IMPROVEMENT] CMake build for windows.#742

Merged
cfsmp3 merged 1 commit intoCCExtractor:masterfrom
saurabhshri:cmake-win-fix
Jun 5, 2017
Merged

[Fix][IMPROVEMENT] CMake build for windows.#742
cfsmp3 merged 1 commit intoCCExtractor:masterfrom
saurabhshri:cmake-win-fix

Conversation

@saurabhshri
Copy link
Copy Markdown
Member

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

CMake now works successfully on Windows.

  • added missing libraries
  • fixed broken linker flags

Thank you linker flags for eating my 3+ hours.
@cfsmp3 cfsmp3 merged commit 51d936b into CCExtractor:master Jun 5, 2017
@saurabhshri saurabhshri deleted the cmake-win-fix branch October 14, 2017 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants