Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Sep 8, 2017

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

When the -out=raw option is used, the ccextractor jumped to spupng output
format, generating broken files in spupng format without CC data.
With this fix, now it generates CC data in McPoodle's Broadcast format.

When the -out=raw option is used, the ccextractor jumped to spupng output
format, generating broken files in spupng format without CC data.
With this fix, now it generates CC data in McPoodle's Broadcast format.
@cfsmp3 cfsmp3 merged commit f8d9e04 into CCExtractor:master Sep 8, 2017
@ghost ghost deleted the fix-out-raw branch September 8, 2017 20:05
hrideshmg pushed a commit to hrideshmg/ccextractor that referenced this pull request Mar 12, 2025
…ctor#775)

* add draft check for PRs

* bug fix and minor refactor

* addings `draft: False` to existing tests

* `ready_for_review` action and tests

* `converted_to_draft` and fixing some tests

* fixing the tests

---------

Co-authored-by: Shivam Kumar Jha <code@thealphadollar.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant