Skip to content

Conversation

@thefar8
Copy link
Contributor

@thefar8 thefar8 commented Dec 2, 2017

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Have updated libGPAC from v0.6.2 to the latest version on their GitHub

Any feedbacks would be appreciated :)

@thefar8 thefar8 changed the title Updated GPAC library to v0.7.0 (#778) [IMPROVEMENT] Updated GPAC library to v0.7.0 (#778) Dec 2, 2017
@thefar8 thefar8 changed the title [IMPROVEMENT] Updated GPAC library to v0.7.0 (#778) [IMPROVEMENT] Updated libGPAC to their latest version (#778) Dec 2, 2017
Copy link
Member

@canihavesomecoffee canihavesomecoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux seems to be fully broken:

https://sampleplatform.ccextractor.org/test/961

Failed to build using builddebug
Failed to build using autoconf
(cmake was already broken)

Please check this out and fix this, this will be necessary to merge this.

@thefar8 thefar8 closed this Dec 2, 2017
@thefar8 thefar8 reopened this Dec 2, 2017
@thefar8
Copy link
Contributor Author

thefar8 commented Dec 2, 2017

Wait
I have to change the whole .c in GPAC too

@thefar8 thefar8 changed the title [IMPROVEMENT] Updated libGPAC to their latest version (#778) [IMPROVEMENT] Updated libGPAC to 0.7.0 (#778) Dec 2, 2017
@cfsmp3
Copy link
Contributor

cfsmp3 commented Dec 3, 2017

Please reopen (or send a new one) when it's ready for review.

@cfsmp3 cfsmp3 closed this Dec 3, 2017
@thefar8 thefar8 changed the title [IMPROVEMENT] Updated libGPAC to 0.7.0 (#778) [IMPROVEMENT] Updated libGPAC to 0.7.1 (#778) Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants