Skip to content

[IMPROVEMENT] Update README and add Installation file.#835

Merged
canihavesomecoffee merged 3 commits intoCCExtractor:masterfrom
MatejMecka:master
Dec 13, 2017
Merged

[IMPROVEMENT] Update README and add Installation file.#835
canihavesomecoffee merged 3 commits intoCCExtractor:masterfrom
MatejMecka:master

Conversation

@MatejMecka
Copy link
Copy Markdown
Contributor

Add INSTALLATION file and update README

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Updated README and added an Installation file for offline users.

Add INSTALLATION file and update README
Comment thread README.md Outdated

cd ccextractor/package_creators
./rpm.sh
To learn more about how to install CCExtractor for your platform check the INSTALLATION.MD file or visit the wiki and choose the operating system you want to do so or click [here](https://github.com/MatejMecka/ccextractor/wiki) to go there.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That link won't do. A wiki isn't good either. You can link to documents in the same repo, see the Sample platform for example.

Comment thread INSTALLATION.MD Outdated
@@ -0,0 +1,181 @@
# Linux
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lacks a good header, an overview to the available options and maybe an introduction.

Comment thread INSTALLATION.MD Outdated
# Installation
CCExtractor runs on all major platforms and getting started and using it is easy!

You can compile it on most platforms using CMake using the `CMakeLists.txt` file stored in `ccextractor/src` autoconf and build scripts designed specifically for your platform.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence doesn't sound very right

Comment thread INSTALLATION.MD Outdated

There are also precompiled binaries for you too use. You can get them from [CCExtractor’s](https://www.ccextractor.org/?id=public:general:downloads) website

### Linux
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why jump in 2 levels?

Comment thread INSTALLATION.MD Outdated
```
sudo yum install -y gcc
sudo yum install -y tesseract-devel
```### Setup
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an error

Comment thread INSTALLATION.MD Outdated
```### Setup
There are 3 ways to set up ccextractor depending on your choice.

1. First and easiest way is to go in the linux folder and use the build script.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using headings with the names of the scripts?

Comment thread INSTALLATION.MD Outdated

Configurations options include dependent libraries which are used for OCR.

---
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with these lines?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line break or separator

Comment thread README.md

cd ccextractor/package_creators
./rpm.sh
To learn more about how to install CCExtractor for your platform check the [installation guide](INSTALLATION.MD).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put this on top of this section, and remove the precompiled binaries section as that's also mentioned in the installation guide.

@canihavesomecoffee canihavesomecoffee merged commit 06c735b into CCExtractor:master Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants