[FIX] Fixed --sentencecap for teletext samples #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahalwal
changed the title
9 tasks
hrideshmg
pushed a commit
to hrideshmg/ccextractor
that referenced
this pull request
Mar 12, 2025
…ine workflow (CCExtractor#842) * Update build commit and runCI script files Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com> * Remove mod_deploy module, update CD Github workflow Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com> * Add build_commit in flask globals Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com> * Add unittests to check when github response is invalid Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com> * Add unittests for request_from_github Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com> * Apply suggestions from code review Co-authored-by: Shivam Kumar Jha <shivam.cs.iit.kgp@gmail.com> --------- Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com> Co-authored-by: Willem <github@canihavesome.coffee> Co-authored-by: Shivam Kumar Jha <shivam.cs.iit.kgp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Fixes #829
--sentencecap works for the given teletext sample.