Skip to content

keshav#854

Closed
KESHAVGOYAL9425 wants to merge 1 commit intoCCExtractor:masterfrom
KESHAVGOYAL9425:master
Closed

keshav#854
KESHAVGOYAL9425 wants to merge 1 commit intoCCExtractor:masterfrom
KESHAVGOYAL9425:master

Conversation

@KESHAVGOYAL9425
Copy link

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

{pull request content here}

@MatejMecka
Copy link
Contributor

Hi there! Welcome to Google Code in!

A Few suggestions for your pull request.

  1. Fill out the Form or Check boxes. They are there for a purpose so please do.
  2. Give your Pull Request a much more useful name. Your current Pull Request name doesn't make sense at all and when someone is going to go back through the commits he won't understand what you did. Based on your files I'd suggest naming

Add Dictionary's for Thirteen reasons why etc..

You get my point. A descriptive title is better than anything else.

  1. Prefix your PR. You have to prefix your Pull Request too here. So in the end how the title is going to look is [IMPROVEMENT] <Title here>

I hope you have a interesting code in and hope this helps you contribute more to Open Source and submit more quality work

@thefar8
Copy link
Contributor

thefar8 commented Dec 27, 2017

plus please don't open too many Pull Request that contain the same thing.
More Pull Request you sent won't make us to review/merge your Pull Request.
You can make changes in your own branch and then if it has already finished, please send us the proper PR.

You can learn git here (so you able to use GitHub more effectively).

Look forward to another contribution :)

@cfsmp3 cfsmp3 closed this Dec 28, 2017
hrideshmg pushed a commit to hrideshmg/ccextractor that referenced this pull request Mar 12, 2025
* Fix /custom endpoint

Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com>

* Fix unittests for /custom endpoint

Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com>

---------

Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants