[Fix] Put OCR specific code inside ifdef#855
Conversation
Removed debug code. No idea why it causes travis fails to build
| sub->prev->start_time, sub->prev->end_time); | ||
| } | ||
| struct cc_bitmap* content = sub->data; | ||
| mprint("\nCurrent subtitle %x (%s)\nStart time: %lld; End time: %lld\n", |
There was a problem hiding this comment.
Most likely it doesn't like this variable being declared in the middle of a block. You may want to try declaring in on top.
There was a problem hiding this comment.
I am not sure. It says there is no ocr_text in cc_bitmap.
Shall we just merge the pr? cuz it's just debug code and doesn't really matter.
|
@harrynull Could you please check if the travis build is trying to build CCExtractor with OCR enabled or not? You can also try keeping this debugging code in an |
|
@saurabhshri That could be the reason. I did not consider that. Thanks! |
|
@harrynull Could you also please change the title to something like "[Fix] Put OCR specific code inside ifdef" before merge? |
harrynull
changed the title
|
@saurabhshri Done :) |
…onfig (CCExtractor#855) * Delete old bot comments and repost Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com> * Remove role of GITHUB_BOT in config Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com> --------- Signed-off-by: Tarun Arora <tarun.arora.030402@gmail.com>
3 participants
Removed debug code. No idea why it causes travis fails to build
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Put debug code into ifdef to avoid failing compilation when OCR is disabled.