Skip to content

Conversation

@harrynull
Copy link
Contributor

@harrynull harrynull commented Jan 10, 2018

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Upgrade libgpac to 0.7.0 0.7.1.

The pr fixes the failing sample, based on @Hori75 's pr #871 .

List of changes I have made: (For future references when upgrading it...)

  • Change box_funcs.c: comment out some of the lines to avoid introduce too many files. See dfb26f49a265c1cf383a4016fc2ca015bcfb7d4d
  • In gpac/configuration.h, comment out all #define GPAC_MEMORY_TRACKING (there are currently two of it) and #else #error "Unknown target platform used with static configuration file" (To avoid compilation errors in Linux)
  • In gpac/isomedia.h, add more constants. See dfb26f49a265c1cf383a4016fc2ca015bcfb7d4d
  • Make gpac/revision.h yourself; update the version.
  • In /gpac/setup.h, change functions like void* gf_malloc(size_t size); to #define gf_malloc malloc (to avoid introducing alloc.c)
  • In isom_write.c, remove line #include <gpac/iso639.h>

Please don't merge until the CI platforms run it

@harrynull harrynull changed the title [WIP] [IMPROVEMENT] Upgrade libgpac based on Hori75's branch [IMPROVEMENT] Upgrade libgpac based on Hori75's branch Jan 10, 2018
@canihavesomecoffee
Copy link
Member

@harrynull The platform will most likely run it in a couple of hours; it's queued as next one to run after the current test finishes.

@cfsmp3 cfsmp3 merged commit a6f2f33 into CCExtractor:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants