Skip to content

[IMPROVEMENT] Minor changes - Add default fonts in the --help#899

Merged
cfsmp3 merged 2 commits intoCCExtractor:masterfrom
harrynull:patch-2
Jan 17, 2018
Merged

[IMPROVEMENT] Minor changes - Add default fonts in the --help#899
cfsmp3 merged 2 commits intoCCExtractor:masterfrom
harrynull:patch-2

Conversation

@harrynull
Copy link
Copy Markdown
Contributor

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Add default fonts in the --help.

Copy link
Copy Markdown
Member

@saurabhshri saurabhshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this sounds better..

Comment thread src/lib_ccx/params.c Outdated
mprint (" comments in the XML file.\n");
mprint (" -font: Specify the full path of the font that is to be used when\n");
mprint (" generating SPUPNG files.\n");
mprint (" generating SPUPNG files. If you don't specify, you need to\n");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If you don't specify --> If not specified

Comment thread src/lib_ccx/params.c Outdated
mprint (" -font: Specify the full path of the font that is to be used when\n");
mprint (" generating SPUPNG files.\n");
mprint (" generating SPUPNG files. If you don't specify, you need to\n");
mprint (" have the default font installed (Helvetica for MacOS, calibri\n");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • MacOS --> macOS
  • calibri --> Calibri

Comment thread src/lib_ccx/params.c Outdated
mprint (" generating SPUPNG files.\n");
mprint (" generating SPUPNG files. If you don't specify, you need to\n");
mprint (" have the default font installed (Helvetica for MacOS, calibri\n");
mprint (" for Windows, and Noto for other Operating Systems\n)");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Operating Systems --> operating systems at their default location.

Copy link
Copy Markdown
Member

@saurabhshri saurabhshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cfsmp3 cfsmp3 merged commit f172c50 into CCExtractor:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants