Skip to content

[IMPROVEMENT] Removed unused import in *.py files#909

Closed
pandeykartikey wants to merge 1 commit intoCCExtractor:masterfrom
pandeykartikey:unused-imports
Closed

[IMPROVEMENT] Removed unused import in *.py files#909
pandeykartikey wants to merge 1 commit intoCCExtractor:masterfrom
pandeykartikey:unused-imports

Conversation

@pandeykartikey
Copy link
Copy Markdown

@pandeykartikey pandeykartikey commented Jan 21, 2018

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Removes all the unused imports in *.py files

@thefar8
Copy link
Copy Markdown
Contributor

thefar8 commented Jan 22, 2018

Have you tried it?

@pandeykartikey
Copy link
Copy Markdown
Author

Yes @thefar8

@pandeykartikey
Copy link
Copy Markdown
Author

@cfsmp3 have a look at this PR.

@pandeykartikey
Copy link
Copy Markdown
Author

@canihavesomecoffee please have a look.

@cfsmp3
Copy link
Copy Markdown
Contributor

cfsmp3 commented Feb 23, 2018

We probably don't want to remove those imports even if they are not being used at this time - after all, it's the "canonical" way to import ccextractor into python.

@cfsmp3 cfsmp3 closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants