[IMPROVEMENT] Update libGPAC #974
Conversation
File changes have been directly inserted from libGPAC master into ccextractor's libGPAC. This has resulted into removal of multiple custom functions and minor changes. These will be rectified in the next step of the updation. Change severity: Very High
We use libGPAC for all our MP4 operations and, this commit updates it to the latest version. All previous changes to the original library were restored post straight file updation and bugs have been removed. change severity: very high
thealphadollar
force-pushed
the
update_gpac
branch
from
bb9c6ea to
ab3bf64
Compare
A small textual guide on how to update dependencies easily and efficiently.
thealphadollar
force-pushed
the
update_gpac
branch
from
ab3bf64 to
8301fd1
Compare
|
@cfsmp3 I inspected the log files for the tests and it seems the problem,
Is it safe to merge the PR? |
|
Is there a guide somewhere on how to upgrade Looking at https://github.com/gpac/gpac/ , the source is a lot different than what is in gpacmp4. Where can I get more information? |
|
Probably not worth the effort until we get a .mp4 file that our current libGPAC doesn't support. |
|
Actually that's why I'm asking #1053 |
|
@NilsIrl I don't really suspect libgpac, more likely a Windows file system issue. |
3 participants
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
We use libGPAC for all our MP4 operations and, this commit updates it to the latest version.
All previous changes to the original library were restored post straight file updation and bugs have been removed.
concerns #961
The updated libGPAC supports the file present in the referenced issue but, unfortunately, the new library is detecting that there are no subtitles in the file.
change severity: very high