Skip to content

[FIX] Fix some minor memory leaks #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cfsmp3 merged 6 commits into from
Jul 18, 2018
Merged

[FIX] Fix some minor memory leaks #989

cfsmp3 merged 6 commits into from
Jul 18, 2018

Conversation

@krushanbauva
Copy link
Contributor

@krushanbauva krushanbauva commented Jun 19, 2018

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • [] I have never used CCExtractor.
  • [] I have used CCExtractor just a couple of times.
  • [] I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Fixed some minor memory leaks, some typographical errors and added some missing declarations.

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Jun 19, 2018

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 0/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 13/14
DVD 3/3
Options 84/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Jun 19, 2018

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 11/13
DVB 3/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 0/10
Teletext 18/21
WTV 13/13
XDS 34/34
CEA-708 13/14
DVD 3/3
Options 83/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@cfsmp3 cfsmp3 merged commit 45ed845 into CCExtractor:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krushanbauva @ccextractor-bot @cfsmp3