Skip to content

Resolve Compiler Warnings for the SIST 1.0.0 Release - #37

Merged
harryswift01 merged 3 commits into
mainfrom
34-bug-investigate-scientific-implementation-warnings
Aug 13, 2026
Merged

Resolve Compiler Warnings for the SIST 1.0.0 Release#37
harryswift01 merged 3 commits into
mainfrom
34-bug-investigate-scientific-implementation-warnings

Conversation

@harryswift01

Copy link
Copy Markdown
Member

Summary

Resolve compiler warnings identified while preparing SIST for the 1.0.0 release.

The changes remove uninitialised state and clarify ambiguous control flow while keeping the existing scientific behaviour as close as possible to the current implementation.

Changes

Initialisation fixes:

  • Avoid using uninitialised MinWindowSize and MaxWindowSize values in the constructors.
  • Initialise profile matrix pointers using the fixed MaxInitialWindowSize bounds.

Cruciform record validation:

  • Initialise cruciform record values before use.
  • Only store complete and valid cruciform energy records.
  • Prevent malformed records from accessing invalid sequence positions.

Compiler warning cleanup:

  • Resolve misleading-indentation warnings in trans_three and trans_compete.
  • Make existing control flow explicit without intentionally changing behaviour.

Impact

  • Both trans_three and trans_compete build cleanly
  • Removes identified uninitialised-state and ambiguous-control-flow warnings.
  • No intentional changes to scientific parameters, defaults, or supported calculations.

@harryswift01 harryswift01 self-assigned this Aug 13, 2026
@harryswift01 harryswift01 added the bug Something isn't working label Aug 13, 2026
@harryswift01
harryswift01 requested a review from jimboid August 13, 2026 15:38

@jimboid jimboid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly like indentation fixes etc resulting in cleaner src. The only really relevant change is the maxwindow change. If the tests are still giving correct answers then safe to merge.

@harryswift01
harryswift01 merged commit aecd19d into main Aug 13, 2026
2 checks passed
@harryswift01
harryswift01 deleted the 34-bug-investigate-scientific-implementation-warnings branch August 13, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Investigate scientific implementation warnings and CLI inconsistencies

2 participants