Resolve Compiler Warnings for the SIST 1.0.0 Release - #37
Merged
harryswift01 merged 3 commits intoAug 13, 2026
Merged
Conversation
jimboid
approved these changes
Aug 13, 2026
jimboid
left a comment
Member
There was a problem hiding this comment.
Looks mostly like indentation fixes etc resulting in cleaner src. The only really relevant change is the maxwindow change. If the tests are still giving correct answers then safe to merge.
harryswift01
deleted the
34-bug-investigate-scientific-implementation-warnings
branch
August 13, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve compiler warnings identified while preparing SIST for the 1.0.0 release.
The changes remove uninitialised state and clarify ambiguous control flow while keeping the existing scientific behaviour as close as possible to the current implementation.
Changes
Initialisation fixes:
MinWindowSizeandMaxWindowSizevalues in the constructors.MaxInitialWindowSizebounds.Cruciform record validation:
Compiler warning cleanup:
trans_threeandtrans_compete.Impact
trans_threeandtrans_competebuild cleanly