Skip to content

CNFT1-3313: Operator dropdown for last name#2001

Merged
joeaxcdw merged 7 commits into
mainfrom
CNFT1-3313-operator-dropdown-last-name
Nov 8, 2024
Merged

CNFT1-3313: Operator dropdown for last name#2001
joeaxcdw merged 7 commits into
mainfrom
CNFT1-3313-operator-dropdown-last-name

Conversation

@joeaxcdw

@joeaxcdw joeaxcdw commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

Description

Implements the operator dropdown for last name. Make these changes:

  • integrate with NBS 6 search/query string including '%' operator for contains
  • minor enhancements to operator select component

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@adamloup-enquizit adamloup-enquizit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: 🐝 Thanks again for fixing the spelling!

Looks good!

@joeaxcdw
joeaxcdw merged commit ad4b50b into main Nov 8, 2024
@joeaxcdw
joeaxcdw deleted the CNFT1-3313-operator-dropdown-last-name branch November 8, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants