Add summarize_scores_with_baseline#130
Merged
Merged
Conversation
dylanhmorris
marked this pull request as ready for review
May 2, 2025 23:06
O957
reviewed
May 6, 2025
damonbayer
reviewed
May 6, 2025
damonbayer
approved these changes
May 6, 2025
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (4)
- NAMESPACE: Language not supported
- R/summarise_scores_with_baseline.R: Language not supported
- man/summarise_scores_with_baseline.Rd: Language not supported
- tests/testthat/test_summarise_scores_with_baseline.R: Language not supported
damonbayer
reviewed
May 6, 2025
damonbayer
requested changes
May 6, 2025
damonbayer
left a comment
damonbayer
left a comment
Collaborator
There was a problem hiding this comment.
Upon further inspection, I found an issue I'd like to see addressed. https://github.com/CDCgov/forecasttools/pull/130/files#r2076035148
damonbayer
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRYify calculation of score ratios and scaled relative skill values alongside absolute metrics