Skip to content

Handle missing values in trajectories_to_quantiles.R#149

Merged
dylanhmorris merged 3 commits into
mainfrom
dmb_handle_missing
Jun 5, 2025
Merged

Handle missing values in trajectories_to_quantiles.R#149
dylanhmorris merged 3 commits into
mainfrom
dmb_handle_missing

Conversation

@damonbayer

Copy link
Copy Markdown
Collaborator

Went with this option instead of na.rm = TRUE for the case when your value is NaN, which would result in a dishonest quantile calculation.

@damonbayer
damonbayer requested a review from dylanhmorris as a code owner June 4, 2025 21:01
@codecov

codecov Bot commented Jun 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.76%. Comparing base (9b1fc01) to head (1bbc2ea).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   63.57%   63.76%   +0.18%     
==========================================
  Files          28       28              
  Lines        1543     1551       +8     
==========================================
+ Hits          981      989       +8     
  Misses        562      562              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dylanhmorris dylanhmorris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @damonbayer! Would you mind adding a basic test?

@damonbayer damonbayer self-assigned this Jun 5, 2025
@damonbayer damonbayer removed their assignment Jun 5, 2025
@damonbayer
damonbayer requested a review from dylanhmorris June 5, 2025 22:23

@dylanhmorris dylanhmorris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @damonbayer!

@dylanhmorris
dylanhmorris merged commit adfc3f5 into main Jun 5, 2025
@dylanhmorris
dylanhmorris deleted the dmb_handle_missing branch June 5, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants