Skip to content

Add filter to shared forecasts#167

Merged
dylanhmorris merged 8 commits into
mainfrom
dhm-filter-forecasts-to-overlap
Jun 23, 2025
Merged

Add filter to shared forecasts#167
dylanhmorris merged 8 commits into
mainfrom
dhm-filter-forecasts-to-overlap

Conversation

@dylanhmorris

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Jun 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (773ce63) to head (d6a8999).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   66.92%   67.59%   +0.66%     
==========================================
  Files          28       29       +1     
  Lines        1657     1691      +34     
==========================================
+ Hits         1109     1143      +34     
  Misses        548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread R/filter_to_shared_forecasts.R Outdated
Comment thread R/filter_to_shared_forecasts.R Outdated
@dylanhmorris
dylanhmorris marked this pull request as ready for review June 16, 2025 17:39
@dylanhmorris
dylanhmorris requested a review from damonbayer June 16, 2025 17:41
Comment thread tests/testthat/test_filter_to_shared_forecasts.R Outdated

@damonbayer damonbayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change requested for tests

@dylanhmorris
dylanhmorris requested a review from damonbayer June 20, 2025 20:19
Comment thread tests/testthat/test_filter_to_shared_forecasts.R Outdated

@damonbayer damonbayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change suggested.

Co-authored-by: Damon Bayer <xum8@cdc.gov>
@dylanhmorris
dylanhmorris enabled auto-merge (squash) June 23, 2025 19:16
@dylanhmorris
dylanhmorris merged commit 0c6d9e5 into main Jun 23, 2025
13 checks passed
@dylanhmorris
dylanhmorris deleted the dhm-filter-forecasts-to-overlap branch June 23, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants