fix: handle filtered criterion summaries - #1011
Merged
Merged
Conversation
Benchmark ResultsHyperfine
CriterionRegressions (slower)
Improvements (faster)
Unchanged / inconclusive (CI crosses 0%)
Not Compared (no baseline yet)
|
RobertJacobsonCDC
requested changes
Jul 16, 2026
RobertJacobsonCDC
left a comment
Collaborator
There was a problem hiding this comment.
This is kind of a nit pick, but can we put everything in the single ixa-bench/criterion/sample_single_excluding.rs file instead of having a new file ixa-bench/criterion/sample_single_excluding_summary.rs for the auxiliary types that are only used in sample_single_excluding.rs and a separate file ixa-bench/tests/sample_single_excluding_summary.rs just for tests? If we really need tests, just make it a tests submodule in ixa-bench/criterion/sample_single_excluding.rs like we normally do.
Also, do we really need the tests for this? I'd be tempted to leave them out, personally. But it's up to you.
Benchmark ResultsHyperfine
CriterionRegressions (slower)
Improvements (faster)
Unchanged / inconclusive (CI crosses 0%)
Not Compared (no baseline yet)
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sample_single_excludingfrom panicking when Criterion filters skip benchmarks.