Will's work on accessibility issues

[wkdewey]

No description provided.

[erinchambers]

Just one question about the empty aria labels for the certainty visualizations (not sure if those are empty to-be-filled-later or if they're for the XSLT to insert values into—let me know!)

[erinchambers]

@wkdewey Do we need to have somebody fill in the empty aria-label attributes? If so, no worries about it here—I can make an issue for it! Just let me know.

[wkdewey]

I am not sure why I made empty aria-labels. I will have to look back over my commits.

[wkdewey]

I put the following in the XSLT:

      <xsl:attribute name="aria-label">
        <!-- FID -->
        <xsl:if test="contains(@who,'nar_') and @direct = 'false' and descendant::certainty">
          <xsl:text>free indirect discourse </xsl:text>
        </xsl:if>
        <!-- INDIRECT -->
        <xsl:if test="not(contains(@who,'nar_')) and @direct = 'false' and descendant::certainty">
          <xsl:text>indirect narration </xsl:text>
        </xsl:if>
        <!-- INTRO TO FID -->
        <xsl:if test="(contains(@who,'nar') and not(contains(@who,'nar_'))) and @direct = 'false'">
          <xsl:text>intro to free indirect discourse</xsl:text>
        </xsl:if>
        <xsl:if test="descendant::certainty"><xsl:text>certainty level</xsl:text><xsl:value-of select="replace(certainty/@degree, '\.', ' ')"></xsl:value-of></xsl:if>
      </xsl:attribute>

Looks like it didn't work as intended

[wkdewey]

Or rather, it worked when there was highlighted text and a certainty level, but it made an empty aria-label where there wasn't highlighted text. There should not be an aria-label on non-highlighted text.

[wkdewey]

resolved

[wkdewey]

I deleted the empty aria-labels. Looks like I need to fix the xslt too.

[wkdewey]

"submitting" so that my pending comments show up

[wkdewey]

Or rather, it worked when there was highlighted text and a certainty level, but it made an empty aria-label where there wasn't highlighted text. There should not be an aria-label on non-highlighted text.

[wkdewey]

I think I've resolved the issues I pointed out in my comments

[erinchambers]

Looks great, thank you!