feat(hip): add vector filter backend - #2002
Closed
tomatotomata wants to merge 1 commit into
Closed
Conversation
Member
|
The associated issue is intended for students to work on - not mass automated submissions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CeedVectorFilterhost and HIP-device implementations to/gpu/hip/refThis follows the remaining HIP work identified in #1830 and ports the already-merged CUDA implementation from #1988. The existing
tests/t129-vector.ccovers the public operation for vector sizes including zero and threshold boundary cases.Validation
git diff --checkpassedhipccnor GNUmake; the HIP source will need the repository CI environment for compile and test validationLLM/GenAI disclosure
I used Codex to help inspect the existing CUDA implementation and draft the HIP adaptation. I reviewed the resulting diff and am responsible for the submitted code.