Promote Field Getters to Public API by jeremylt · Pull Request #806 · CEED/libCEED

jeremylt · 2021-09-08T15:34:23Z

I also want to add this to the Rust interface to make my mini-app development in Rust easier.

jedbrown

Thanks for taking the lead on this.

jeremylt · 2021-09-09T17:42:22Z

The Julia CI issue seems to be related the Release/Dev test split.

jeremylt · 2021-09-10T18:19:00Z

Fun new OCCA backend bug! The OCCA backend attempts to fully build and validate an Operator as part of its process for destroying an Operator, resulting in t508 failing. I'm investigating how best to fix this. There is no reason whatsoever to validate the operator fields as a prerequsite to destroying an Operator.

jeremylt · 2021-09-10T19:05:41Z

Ok, the OCCA backend is pretty opaque to me and my C++ is not too great. I'll probably need help to fix this the right way. We could also just skip that test for OCCA and file another issue against the backend to be fixed sometime in the future.

jeremylt · 2021-09-10T23:28:21Z

While we're here, any objections to raising these to the public API level?

CEED_EXTERN int CeedOperatorGetNumElements(CeedOperator op, CeedInt *num_elem);
CEED_EXTERN int CeedOperatorGetNumQuadraturePoints(CeedOperator op,
    CeedInt *num_qpts);

maybe also this one?

CEED_EXTERN int CeedOperatorGetQFunction(CeedOperator op, CeedQFunction *qf);

jedbrown · 2021-09-11T04:08:45Z

While we're here, any objections to raising these to the public API level?

CEED_EXTERN int CeedOperatorGetNumElements(CeedOperator op, CeedInt *num_elem);
CEED_EXTERN int CeedOperatorGetNumQuadraturePoints(CeedOperator op,
    CeedInt *num_qpts);

maybe also this one?

CEED_EXTERN int CeedOperatorGetQFunction(CeedOperator op, CeedQFunction *qf);

Just need to clarify what happens if you call those on a composite operator. Either it consults each of its sub-operators and aggregates the result or it returns error (or something out of band, like -1).

Add ceedversion_ge, which performs the same comparison as the macro CEED_VERSION_GE. Non-release builds compare as infinity.

…function opts

…ements, NumQuadraturePoints] to public API

jeremylt · 2021-09-13T22:42:45Z

Ok, this all should be fine to merge now - I think I'll talk a bit about our modern interfaces in my PSAAP slides

jedbrown

LGTM any time. We could merge now and use ref_cast later. I'd love to make progress on #807 or #805 this week.

jedbrown · 2021-09-14T15:44:59Z

+            let slice = unsafe {
+                std::slice::from_raw_parts(
+                    &ptr as *const bind_ceed::CeedElemRestriction as *const crate::ElemRestriction,
+                    1 as usize,
+                )
+            };
+            ElemRestrictionOpt::Some(&slice[0])


I found this safe and less contorted way to do this. https://docs.rs/ref-cast/1.0.6/ref_cast/

Co-authored-by: Jed Brown <jed@jedbrown.org>

jeremylt added enhancement design interface 0-WIP labels Sep 8, 2021

jeremylt self-assigned this Sep 8, 2021

jeremylt commented Sep 8, 2021

View reviewed changes

Comment thread doc/sphinx/source/releasenotes.md

jeremylt force-pushed the jeremy/get-fields branch from 8f7aefd to 5c6e72f Compare September 8, 2021 20:48

jeremylt commented Sep 8, 2021

View reviewed changes

Comment thread rust/libceed/src/operator.rs Outdated

jeremylt added 1-In Review and removed 0-WIP labels Sep 9, 2021

jeremylt requested a review from jedbrown September 9, 2021 16:06

jeremylt force-pushed the jeremy/get-fields branch from d2534d6 to 8b44697 Compare September 9, 2021 16:11

jedbrown reviewed Sep 9, 2021

View reviewed changes

Comment thread rust/libceed/src/operator.rs Outdated

jeremylt force-pushed the jeremy/get-fields branch from e338f3a to b18e302 Compare September 9, 2021 17:29

jeremylt force-pushed the jeremy/get-fields branch 5 times, most recently from 634576b to d27cf79 Compare September 9, 2021 22:29

jeremylt commented Sep 10, 2021

View reviewed changes

Comment thread rust/libceed/src/operator.rs

jeremylt commented Sep 10, 2021

View reviewed changes

Comment thread interface/ceed-operator.c

jeremylt mentioned this pull request Sep 10, 2021

OCCA Backend Builds Operator to Destroy #808

Closed

pazner reviewed Sep 10, 2021

View reviewed changes

Comment thread julia/LibCEED.jl/src/LibCEED.jl

jeremylt force-pushed the jeremy/get-fields branch from b8d1006 to 9335683 Compare September 10, 2021 22:35

jedbrown reviewed Sep 11, 2021

View reviewed changes

Comment thread rust/libceed/src/qfunction.rs

jeremylt force-pushed the jeremy/get-fields branch 2 times, most recently from 6ebdb00 to c4ba7f8 Compare September 13, 2021 20:21

jeremylt commented Sep 13, 2021

View reviewed changes

Comment thread rust/libceed/src/operator.rs

jeremylt and others added 17 commits September 13, 2021 15:38

interface - refactor *GetFields to include number of fields

7e7773b

interface - promote field getters to public API

43bbe13

interface - add CeedOperatorGetFieldName

28567f8

qf/op - make immutability conditions explicit

f04ea55

doc - add single precision release note

f479eb2

doc - add advanced function classification

e9b533f

[Julia] update bindings

443fcf8

[Julia] Bump minimum_libceed_version. Change version comparison logic.

c33c11c

Add ceedversion_ge, which performs the same comparison as the macro CEED_VERSION_GE. Non-release builds compare as infinity.

rust - remove unwrap() in documentation in favor of ?

c68be7a

rust - add is_some() and is_none() for vector/elemrestriction/basis/q…

e03682a

…function opts

interface - promote *GetCeed to public API; promote OperatorGet[NumEl…

b7c9bbd

…ements, NumQuadraturePoints] to public API

rust - rework error handling to simply Rust libCEED object structs

1142270

rust - add num_elements and num_quadrature_points for Operator

3f2759c

rust - add QFunction and Operator fields with getters

08778c6

rust - export Result for libceed crate

89d15d5

rust - add missing ?s

d7f0179

rust - creation of vector view may fail

e78171e

jeremylt force-pushed the jeremy/get-fields branch from 20c434f to e78171e Compare September 13, 2021 21:39

jeremylt commented Sep 13, 2021

View reviewed changes

Comment thread rust/libceed/src/lib.rs Outdated

jeremylt added 2 commits September 13, 2021 16:19

rust - drop extra 'Ceed' in some type names

2ba8e59

rust - tidy exports in prelude

4d27c89

jedbrown approved these changes Sep 14, 2021

View reviewed changes

doc - update release notes

ce4822f

Co-authored-by: Jed Brown <jed@jedbrown.org>

jeremylt merged commit 0b54870 into main Sep 14, 2021

jeremylt deleted the jeremy/get-fields branch September 14, 2021 16:48

Conversation

jeremylt commented Sep 8, 2021

Uh oh!

Uh oh!

Uh oh!

jedbrown left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeremylt commented Sep 9, 2021

Uh oh!

Uh oh!

Uh oh!

jeremylt commented Sep 10, 2021

Uh oh!

jeremylt commented Sep 10, 2021

Uh oh!

Uh oh!

jeremylt commented Sep 10, 2021

Uh oh!

jedbrown commented Sep 11, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeremylt commented Sep 13, 2021

Uh oh!

jedbrown left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jedbrown Sep 14, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants