Skip to content

BibCirculation: reset ILL overdue_letter_number#161

Closed
mvesper wants to merge 121 commits intoCERNDocumentServer:prodfrom
mvesper:cds_ill_recall_mail
Closed

BibCirculation: reset ILL overdue_letter_number#161
mvesper wants to merge 121 commits intoCERNDocumentServer:prodfrom
mvesper:cds_ill_recall_mail

Conversation

@mvesper
Copy link
Copy Markdown

@mvesper mvesper commented Nov 18, 2015

  • A ILL is currently extended by manually updating the due_date of
    that ILL, this leads to the following issue:
    A user receives an ILL recall letter, therefore gets the ILL extended
    at the library.
    The next ILL recall letter will be of the second category, since the
    overdue_letter_number never gets reseted.
  • Introduces the new function update_ill_request_letter_number
  • Changes the overdue_letter_number in case the updated due_date is a
    later date than the current due_date in
    ill_request_details_step2.

Signed-off-by: Martin Vesper martin.vesper@cern.ch

Patrick Glauner and others added 30 commits September 1, 2015 15:51
 * Improves database layer to send email notification faster.

 * Extends regression tests for this improvement.

 * Applies minor clean-up.
 * Avoids redundant creations of blacklist.
* Makes test suite independent from PDF extraction process.
  (closes inveniosoftware#1590)

* Simplifies test suite.

Signed-off-by: Patrick Glauner <patrick.oliver.glauner@cern.ch>
* Removes unbalanced double quotation marks.

Signed-off-by: Patrick Glauner <patrick.oliver.glauner@cern.ch>
…on-test-solrutils

SolrUtils: reliable regression test suite
 * Adds checkbox to search terms also in to fulltext to the add
   to search interface.

Signed-off-by: Patrick Glauner <patrick.oliver.glauner@cern.ch>
…its-phrase

WebSearch: new parsing of unbalanced phrase queries
 * Ranks fulltext and metadata properly by default.

Signed-off-by: Patrick Glauner <patrick.oliver.glauner@cern.ch>
 * Ceils ranking scores to avoid anomalies.

Signed-off-by: Patrick Glauner <patrick.oliver.glauner@cern.ch>
* Filters a record based on MARC code.

* Supports wildcards in identifiers and subfield code.

Signed-off-by: Patrick Glauner <patrick.oliver.glauner@cern.ch>
* Supports filtering per MARC tag, identifier and subfield.

Signed-off-by: Patrick Glauner <patrick.oliver.glauner@cern.ch>
* Adds six CERN specific URL handlers.

Signed-off-by: Ludmila Marian <ludmila.marian@gmail.com>
* Push video to youtube (closes inveniosoftware#1664)

* Fixes to support CERN SITES

* Fix authentication result object check

Signed-off-by: Harris Tzovanakis <me@drjova.com>
…yout-cds

WebStyle: add CERN specific URL handlers
Bibencode: Video: Push video to youtube

Conflicts:
	modules/webstyle/lib/webinterface_layout.py
* Creates ldap_cern plugin that can be used to retrieve information from
  LDAP at CERN (it's faster than the LDAP module in bibcirculation due
  to the modified queries and more generic - it returns lists with all
  users that match the query, so the filtering can be done outside of
  this plugin).
* Added disabled-by-default config options for Elasticsearch logging.

* When Elasticsearch logging is configured, don't populate rnkPAGEVIEWS and
  rnkDOWNLOADS.

Signed-off-by: Joe MacMahon <joe.macmahon@cern.ch>
- Now points to the CERNDocumentServer fork rather than my development repo.

- ES on master is for CDS only.

Signed-off-by: Joe MacMahon <joe.macmahon@cern.ch>

will be ignored, and an empty message aborts the commit.  # On branch
elasticsearch_logging # Your branch and 'origin/elasticsearch_logging' have
diverged, # and have 4 and 4 different commits each, respectively.  # (use "git
pull" to merge the remote branch into yours) # # Changes to be committed: #
modified: ../../../requirements.txt #
* register_schema is relatively heavy on the cluster, and with our current
  apache config, it is run every 10000 requests.

Signed-off-by: Joe MacMahon <joe.macmahon@cern.ch>
* Also adds a flag for when a bot agent-string was found in the user-agent

Signed-off-by: Joe MacMahon <joe.macmahon@cern.ch>
* Added disabled-by-default config options for Elasticsearch logging.

* When Elasticsearch logging is configured, don't populate rnkPAGEVIEWS and
  rnkDOWNLOADS.

Signed-off-by: Joe MacMahon <joe.macmahon@cern.ch>
* Adds `loanrequest` schema for `Lumberjack`.

* Adds custom events elastic search logging.

Signed-off-by: Harris Tzovanakis <me@drjova.com>
WebStat: register custom events on es

 Conflicts:
	config/invenio.conf
	modules/bibdocfile/lib/bibdocfile.py
	modules/bibrank/lib/bibrank_downloads_similarity.py
	modules/miscutil/lib/inveniocfg.py
	requirements.txt
* Record stats are being loaded from elasticsearch if elasticsearch is
  enabled (if not, they are being loaded from DB as before).

Signed-off-by: Sebastian Witowski <sebastian.witowski@cern.ch>
* FIX Handles the scenario where the
  `selected_external_collections_infos` is `None`.

Signed-off-by: Esteban J. G. Gabancho <esteban.gabancho@gmail.com>
switowski and others added 19 commits September 1, 2015 17:07
…ization-fixes-and-improvements

Legacy personalization fixes and improvements

 Conflicts:
	modules/webcomment/lib/webcomment.py
	modules/webcomment/lib/webcomment_templates.py
	modules/webstyle/img/Makefile.am
* BETTER Corrects subfield usage when displaying the DOI qualifying
  information, changing subfield `y` (not valid) by `q`.

Signed-off-by: Esteban J. G. Gabancho <esteban.gabancho@gmail.com>
* BETTER Cleans the port from the user's IP preventing issues in
  future manipulations of it.

Reviewed-by: Samuele Kaplun <samuele.kaplun@cern.ch>
Signed-off-by: Esteban J. G. Gabancho <esteban.gabancho@gmail.com>
…doi-display

BibFormat: correct MARC field usage in bfe_doi
* Improves `webinterface_handler_wsgi` PEP8 code style.

Signed-off-by: Esteban J. G. Gabancho <esteban.gabancho@gmail.com>
…sgi-ip

WebStyle: wsgi handler IP parser enhancement

 Conflicts:
	modules/webstyle/lib/webinterface_handler_wsgi.py
* FIX Adds the proper language parameter on tabs if the user has
  selected different language from the browser preferred. (closes
  inveniosoftware#308)

Signed-off-by: Harris Tzovanakis <me@drjova.com>
* Fixes the order of `firstname` and `lastname` in `typeahead` to be
  consistent with `LDAP`. (closes #cds-655)

* Closes inveniosoftware#127 by cherry-pick

Signed-off-by: Harris Tzovanakis <me@drjova.com>
WebSearch: tabs miss language parameter
Signed-off-by: Esteban J. G. Gabancho <esteban.gabancho@gmail.com>
Signed-off-by: Esteban J. G. Gabancho <esteban.gabancho@gmail.com>
* Changes in main navigation menu: Training->Learning
* The WebNews module that will be responsible for presenting the site's news
  to the users and keeping a history of them.

* This first release includes the tooltip functionality and the database
  structure.

  (addresses inveniosoftware#1288)
…n_navigation

Change in main navigation menu: Training->Learning
WebNews: New module to display and manage news

 Conflicts:
	modules/webstyle/lib/webinterface_layout.py
* Merge pull request inveniosoftware#89 drjova/fix-requirement.

* NOTE This problem should be addressed in invenio#2431.
* A ILL is currently extended by manually updating the *due_date* of
  that ILL, this leads to the following issue:
  A user receives an ILL recall letter, therefore gets the ILL extended
  at the library.
  The next ILL recall letter will be of the second category, since the
  *overdue_letter_number* never gets reseted.

* Introduces the new function *update_ill_request_letter_number*

* Changes the *overdue_letter_number* in case the updated due_date is a
  later date than the current due_date in
  *ill_request_details_step2*.

Signed-off-by: Martin Vesper <martin.vesper@cern.ch>
@egabancho
Copy link
Copy Markdown
Member

can you make a PR also to https://github.com/inveniosoftware/invenio and mention it here?

@mvesper
Copy link
Copy Markdown
Author

mvesper commented Feb 3, 2016

Created the PR for invenio: inveniosoftware#3592

egabancho added a commit that referenced this pull request Mar 10, 2016
  BibCirculation: reset ILL overdue_letter_number
@egabancho
Copy link
Copy Markdown
Member

egabancho commented Mar 10, 2016

Merged manually with the changes mentioned in inveniosoftware#3592 (comment)

@egabancho egabancho closed this Mar 10, 2016
egabancho added a commit that referenced this pull request May 9, 2016
…_recall_mail

  BibCirculation: reset ILL overdue_letter_number

  Notes:
    Update accordingly to Tibor's comments in inveniosoftware#3592
ludmilamarian pushed a commit that referenced this pull request Oct 27, 2016
…_recall_mail

  BibCirculation: reset ILL overdue_letter_number

  Notes:
    Update accordingly to Tibor's comments in inveniosoftware#3592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants