Increaed EC2 Tier and added elastic ip

[NickSavino]

No description provided.

[qodo-code-review]

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Review Summary by Qodo

Upgrade EC2 tier and add Elastic IP allocation

✨ Enhancement

Walkthroughs

Description

• Upgraded EC2 instance type to t3.xlarge for improved performance
• Added Elastic IP allocation and association to EC2 instance
• Removed hardcoded AMI lookup, now accepts AMI ID as variable
• Refactored instance type to configurable variable parameter

Diagram

flowchart LR
  var["Variables: instance_type, ami_id"]
  compute["Compute Module"]
  ec2["EC2 Instance t3.xlarge"]
  eip["Elastic IP"]
  assoc["EIP Association"]
  output["Public IP Output"]
  
  var -- "instance_type, ami_id" --> compute
  compute -- "creates" --> ec2
  compute -- "creates" --> eip
  compute -- "associates" --> assoc
  eip -- "provides" --> output

Loading

File Changes

1. infra/env/prod/main.tf ⚙️ Configuration changes +3/-3

Pass instance type to compute module

• Added instance_type variable parameter to compute module
• Aligned variable assignments with consistent formatting
• Removed blank line between variable assignments

infra/env/prod/main.tf

---

2. infra/env/prod/variables.tf ⚙️ Configuration changes +5/-0

Add instance type variable with defaults

• Added new instance_type variable with default value t3.xlarge
• Removed default value from ami_id variable to make it required

infra/env/prod/variables.tf

---

3. infra/modules/compute/main.tf ✨ Enhancement +13/-17

Add Elastic IP and remove AMI lookup

• Removed hardcoded AMI data source lookup for Amazon Linux 2023
• Added aws_eip resource for Elastic IP allocation
• Added aws_eip_association resource to attach EIP to EC2 instance
• Instance now uses var.instance_type and var.ami_id parameters

infra/modules/compute/main.tf

---

View more (1)

4. infra/modules/compute/outputs.tf ✨ Enhancement +10/-10

Output Elastic IP instead of instance IP

• Updated public_ip output to return Elastic IP address instead of instance public IP
• Reformatted file with consistent line endings

infra/modules/compute/outputs.tf

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

1. Ephemeral public IP still enabled 🐞 Bug ⛨ Security

Description

The compute module now allocates/associates an Elastic IP and outputs it as public_ip, but the
instance is still configured to auto-assign a public IP at launch, creating a window where the
instance has a different public IP than the intended EIP. This can break IP allowlists/operational
workflows and briefly expose an unexpected public address during instance create/replace.

Code

infra/modules/compute/main.tf[R102-113]

+resource "aws_eip" "this" {
+  domain = "vpc"
+
+  tags = merge(var.tags, {
+    Name = "${var.name_prefix}-eip"
+  })
+}
+
+resource "aws_eip_association" "this" {
+  instance_id   = aws_instance.this.id
+  allocation_id = aws_eip.this.id
}

Evidence

aws_instance.this is configured to auto-assign a public IP, while the PR adds an EIP and
associates it to the instance and changes the exported public IP to the EIP. With the subnet also
configured to map public IPs on launch, the instance will get an ephemeral public IP first and then
be switched to the EIP after association, creating a temporary second/incorrect public address.

infra/modules/compute/main.tf[86-100]
infra/modules/compute/main.tf[102-113]
infra/modules/compute/outputs.tf[5-7]
infra/modules/network/main.tf[57-68]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The EC2 instance is still configured to receive an auto-assigned public IP (`associate_public_ip_address = true`) even though the module now allocates and associates an Elastic IP and exports that EIP as the instance public IP.

### Issue Context
This creates a launch/replace window where the instance has a different public IP than the intended EIP, which can break IP allowlists and briefly expose an unexpected address.

### Fix Focus Areas
- infra/modules/compute/main.tf[86-95]
- infra/modules/compute/main.tf[102-113]
- (Optional) infra/modules/network/main.tf[57-68]

### Suggested change
Set `associate_public_ip_address = false` on `aws_instance.this` (and, if desired, ensure public subnet behavior aligns with EIP-only exposure).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

2. Missing EOF newlines 🐞 Bug ⚙ Maintainability

Description

Terraform files touched in this PR are missing a trailing newline at end-of-file, which commonly
causes formatter/linter failures and noisy diffs.

Code

infra/env/prod/variables.tf[R22-29]

variable "ami_id" {
  type = string
+}
+
+variable "instance_type" {
+  type    = string
+  default = "t3.xlarge"
}

Evidence

The PR diff explicitly marks \ No newline at end of file for multiple updated Terraform files,
indicating they were saved without a final newline.

infra/env/prod/variables.tf[22-29]
infra/modules/compute/main.tf[110-113]
infra/modules/compute/outputs.tf[9-11]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
Files modified in this PR are missing a trailing newline at EOF.

### Issue Context
Many formatters/linters and some CI checks expect a final newline; missing it causes avoidable diffs and occasional tooling warnings.

### Fix Focus Areas
- infra/env/prod/variables.tf[22-29]
- infra/modules/compute/main.tf[110-113]
- infra/modules/compute/outputs.tf[9-11]

### Suggested change
Add a final newline to each affected file (running `terraform fmt` typically fixes this automatically).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more