fix(header): preserve existing @Last modified by identity unless forced by cldmv-bot[bot] · Pull Request #25 · CLDMV/fix-headers

cldmv-bot · 2026-08-09T03:50:09Z

🚀 What's Changed

💥 Breaking Changes

No breaking changes

✨ Features

No new features

🐛 Bug Fixes

types(core): regenerate fix-headers.d.mts for forceLastModifiedAuthorUpdate (fix(header): preserve existing @Last modified by identity unless forced #25) (8a2e4d8)
fix(header): stop forced author updates from cascading into last-modified identity (fix(header): preserve existing @Last modified by identity unless forced #25) (e067f9d)
fix(header): preserve existing @last modified by identity unless forced (fix(header): preserve existing @Last modified by identity unless forced #25) (0edef4e)

📦 Dependencies

No dependency updates

🔧 Other Changes

types(core): regenerate full declaration output, not a hand-trimmed subset (fix(header): preserve existing @Last modified by identity unless forced #25) (b862a90)
test(core-edge): make force-last-modified-update fixture copyright year dynamic (fix(header): preserve existing @Last modified by identity unless forced #25) (efc50de)

👥 Contributors

@Shinrai

The comparison header always stamped the current runner's git identity into @last modified by, so any machine whose git config user.name differed from what was recorded in existing headers flagged nearly every file as changed purely from an identity mismatch (1551/1565 in one observed run), even with zero real content change. Add extractHeaderLastModifiedIdentity() to parse the existing @last modified by line and preserve it in the comparison header unless the new forceLastModifiedAuthorUpdate option (--force-last-modified-author-update) is set, mirroring how @Author/@Email is already gated behind forceAuthorUpdate. Uses a dedicated flag rather than reusing forceAuthorUpdate since the two identities are independently meaningful to refresh. Closes #24

Copilot

Pull request overview

This PR adjusts the header-rewriting engine so an existing header’s @Last modified by identity is preserved (and does not trigger a rewrite) unless explicitly forced, and adds a new CLI/API option to force updating the last-modified identity.

Changes:

Add forceLastModifiedAuthorUpdate option to preserve existing @Last modified by identity by default, with an override to force updating it.
Extend CLI parsing/help text and README documentation to expose --force-last-modified-author-update.
Add/adjust Vitest coverage to validate preservation vs forced update behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/core-edge.test.vitest.mjs	Adds a no-op preservation test and a force-update test for last-modified identity behavior.
tests/cli.test.vitest.mjs	Adds coverage for parsing `--force-last-modified-author-update`.
src/core/fix-headers.mjs	Implements extraction/preservation of existing `@Last modified by` identity unless forced.
src/cli.mjs	Documents and parses the new `--force-last-modified-author-update` flag.
README.md	Documents the new option and clarifies default preservation behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…ar dynamic The fixture header hard-coded a 2013-2026 copyright range, which mismatches the tool's default (current year) regardless of forceLastModifiedAuthorUpdate — the test would still report filesUpdated: 1 even if the force flag were a no-op, since the copyright-line mismatch alone forces the rewrite. Match the sibling preservation test's pattern of a dynamic current-year range so the force flag is the only reason the header changes. Addresses review comment on PR #25.

Shinrai · 2026-08-09T04:33:54Z

Resolves #24 — closed when this ships to the default branch.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/core/fix-headers.mjs:308

forceLastModifiedAuthorUpdate only affects the comparison header (used to decide whether a file needs an update). When needsUpdate is true for any other reason, the subsequent buildHeader(...) call still hard-codes lastModifiedByName/lastModifiedByEmail to the current detected author, so @Last modified by will change even when the new flag is not set. This appears to contradict the PR intent/docs of preserving the existing last-modified identity unless forcing it; consider applying the same conditional (shouldForceLastModifiedAuthorUpdate ? fileMetadata : existingLastModifiedIdentity || fileMetadata) to the needsUpdate ? buildHeader(...) branch as well.

			lastModifiedByName: shouldForceLastModifiedAuthorUpdate
				? fileMetadata.authorName
				: existingLastModifiedIdentity.authorName || fileMetadata.authorName,
			lastModifiedByEmail: shouldForceLastModifiedAuthorUpdate
				? fileMetadata.authorEmail

…fied identity forceLastModifiedAuthorUpdate only gated the comparison header used to decide whether a rewrite was needed. Once any other reason triggered needsUpdate (e.g. forceAuthorUpdate forcing createdBy to differ, or a malformed/missing @last modified time repair), the actual rewritten header unconditionally stamped the current runner's identity into @last modified by, bypassing the flag entirely and defeating the point of splitting it from forceAuthorUpdate. Apply the same preserve-unless-forced gate to the rewrite branch. @last modified time still always refreshes to now on any real rewrite — only the identity is gated. Addresses suppressed review finding on PR #25.

Shinrai · 2026-08-09T05:28:34Z

Addressed the suppressed finding from the latest review (src/core/fix-headers.mjs:308): forceLastModifiedAuthorUpdate only gated the comparison header used to decide whether a rewrite was needed. Once any other reason triggered needsUpdate — e.g. forceAuthorUpdate forcing createdBy to differ, or a malformed/missing @Last modified time repair — the rewritten header unconditionally stamped the current runner's identity into @Last modified by, bypassing the flag and defeating the point of splitting it from forceAuthorUpdate.

Confirmed by reproduction: forceAuthorUpdate: true alone (no forceLastModifiedAuthorUpdate) was overwriting @Last modified by to the current identity instead of preserving it.

Fixed in e067f9d — applied the same preserve-unless-forced gate to the rewrite branch. @Last modified time still always refreshes to now on any real rewrite; only the identity is gated. Added a regression test (does not cascade a forced author update into the last-modified identity of an unrelated rewrite) and strengthened the existing force-author-update test with the missing @Last modified by assertion.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/core/fix-headers.mjs:33

FixHeadersOptions now documents forceLastModifiedAuthorUpdate, but the published TypeScript declarations still don’t include this option (e.g. types/src/core/fix-headers.d.mts only has forceAuthorUpdate / useGpgSignerAuthor). This will prevent TS consumers from using the new flag without type errors; please update the declarations (or the generation step) to keep the public API in sync.

 *  configFile?: string,
 *  sampleOutput?: boolean,
 *  forceAuthorUpdate?: boolean,
 *  forceLastModifiedAuthorUpdate?: boolean,
 *  useGpgSignerAuthor?: boolean,

…Update The published TypeScript declarations were out of sync with the JSDoc source after adding forceLastModifiedAuthorUpdate to FixHeadersOptions, which would have produced type errors for TS consumers using the new flag. Regenerated via the project's own types:build script and kept only the line this PR's change touches — the regeneration also surfaced unrelated pre-existing drift in constants.d.mts, file-discovery.d.mts, and detectors/index.d.mts from other features already merged into next, which is out of scope here and left untouched. Addresses suppressed review finding on PR #25.

Shinrai · 2026-08-09T05:58:09Z

Addressed the suppressed finding from the latest review (src/core/fix-headers.mjs:33): the FixHeadersOptions JSDoc documented forceLastModifiedAuthorUpdate, but the committed TypeScript declarations (types/src/core/fix-headers.d.mts) hadn't been regenerated, so TS consumers would hit a type error using the new flag.

Fixed in 8a2e4d8 — regenerated via npm run types:build and kept only the line this PR's change touches. The regeneration also surfaced unrelated pre-existing drift in types/src/constants.d.mts, types/src/core/file-discovery.d.mts, and types/src/detectors/index.d.mts (stale declarations for the .gitignore support / root-anchor ignores feature already merged into next) — that's out of scope for this PR so I reverted those files and left them as-is. Worth a separate follow-up to regenerate types/ cleanly against current next.

…ubset The previous commit manually stripped the gitignore-related lines out of the tsc-regenerated declarations to keep the diff scoped to this PR's own change. That was wrong: declaration output is fully deterministic from source, so trimming it just means the file ships already stale the moment this PR merges (missing gitignore, which this branch's own source already declares). Regenerate the full, untrimmed output via npm run types:build instead — picking up the pre-existing gitignore/root-anchor-ignores (74c34da) declaration drift alongside this PR's forceLastModifiedAuthorUpdate addition, so next isn't left stale in either direction regardless of merge order.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Shinrai requested a lite review from Copilot August 9, 2026 04:06

Copilot started reviewing on behalf of Shinrai August 9, 2026 04:06 View session

Copilot AI reviewed Aug 9, 2026

View reviewed changes

Comment thread tests/core-edge.test.vitest.mjs Outdated

Shinrai requested a lite review from Copilot August 9, 2026 04:37

Copilot started reviewing on behalf of Shinrai August 9, 2026 04:37 View session

Copilot AI reviewed Aug 9, 2026

View reviewed changes

Shinrai requested a lite review from Copilot August 9, 2026 05:40

Copilot started reviewing on behalf of Shinrai August 9, 2026 05:41 View session

Copilot AI reviewed Aug 9, 2026

View reviewed changes

Shinrai mentioned this pull request Aug 9, 2026

chore(types): regenerate stale declarations for .gitignore support (v1.3.0) #26

Closed

Shinrai requested a lite review from Copilot August 9, 2026 06:03

Copilot started reviewing on behalf of Shinrai August 9, 2026 06:03 View session

Copilot AI reviewed Aug 9, 2026

View reviewed changes

Shinrai approved these changes Aug 9, 2026

View reviewed changes

Shinrai merged commit c4444e8 into next Aug 9, 2026
24 checks passed

cldmv-bot Bot deleted the fix/preserve-last-modified-identity branch August 9, 2026 06:08

This was referenced Aug 9, 2026

release: v1.3.9 - bump @types/node from 26.1.1 to 26.1.2 in the patch… #23

Merged

Existing headers are rewritten tree-wide when the runner's git identity differs — @Last modified by refresh must be opt-in, not the default #24

Closed

Navigation Menu

Uh oh!

fix(header): preserve existing @Last modified by identity unless forced - #25

fix(header): preserve existing @Last modified by identity unless forced#25
Shinrai merged 5 commits into
nextfrom
fix/preserve-last-modified-identity

cldmv-bot Bot commented Aug 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Shinrai commented Aug 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Shinrai commented Aug 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Shinrai commented Aug 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

cldmv-bot Bot commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 What's Changed

💥 Breaking Changes

✨ Features

🐛 Bug Fixes

📦 Dependencies

🔧 Other Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Shinrai commented Aug 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Shinrai commented Aug 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Shinrai commented Aug 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cldmv-bot Bot commented Aug 9, 2026 •

edited

Loading