Refactor (packages/web/src/middleware.ts): Found 17 lines of identical code in 2 locations (mass = 129) - #56
Open
adeleeuw17 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #54
Type of change
What does this PR do?
Qlty flagged 17 duplicate lines between packages/web/src/middleware.ts and packages/console/app/src/lib/language.ts. Both files parsed Accept-Language headers into a sorted list of pairs separately.
I moved that parsing into a new parseAcceptLanguage function in packages/web/src/i18n/locales.ts, since middleware.ts already imports functions from there. I also moved localeFromAcceptLanguage into the same file, because middleware.ts imports astro:middleware and can't be loaded in a plain test runner.
How did you verify your code works?
I added packages/web/src/middleware.test.ts with 8 tests covering both functions: null input, q-value sorting and defaulting, empty segments, wildcard skipping, and no-match fallback. All pass. Coverage on locales.ts is 93.3% functions / 90.4% lines, and the uncovered lines are pre-existing code I didn't touch. Reran qlty smells on middleware.ts and it's clean. oxlint on the changed files shows 0 warnings.
Screenshots / recordings
qlty before:
qlty after:
Checklist
If you do not follow this template your PR will be automatically rejected.