Add transform base class and example notebooks. Finalise docs - #30
Merged
Conversation
…ration for pre-FFT anti-aliasing
… for block integration
…se mapping explanation to transforms.py. Updated unit tests to use appropriate reference cases
…ith compat low-n Sersic, added transform base class, added example notebooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes the addition of a transform base class which implements backend, data-type, and coordinate management for each transform class to inherit from. This is intended to make it simpler for users to define their own custom transform classes without needing to worry about how the BATSim backend works.
It also covers a moderate bug fix, in which specific compact, low-n Sersic galaxies with were rendering strangely. To combat this, we have made the supersampling reduction factor from block integration more conservative.
It additionally includes the addition of some example notebooks. More to come...