feat: Java 21 modernization — wms

[devin-ai-integration]

Description of the Change

Conservative Java 21 modernization of the gov.nasa.worldwind.wms package (8 files scoped, 5 files changed). All changes are internal implementation details — no public API signatures were modified.

Before / After Counts

Pattern	Before	After	Delta
Redundant type arguments (diamond <>)	16	0	−16
Pattern-matching instanceof opportunities	3	3 (all converted)	−3 casts
Anonymous SAM class → lambda	1	0	−1
StringBuffer in local scope → StringBuilder	2	0	−2
Unnecessary raw-type (Map.Entry) casts	5	0	−5

Changes by File

• Capabilities.java: Diamond operator ×11, pattern-matching instanceof ×2, SAM lambda ×1
• Request.java: Diamond operator ×1, StringBuffer → StringBuilder ×1, raw-type cast removal ×5
• WMSTiledImageLayer.java: StringBuffer → StringBuilder ×2, pattern-matching instanceof ×1
• CapabilitiesV111.java: Diamond operator ×2
• CapabilitiesV130.java: Diamond operator ×2

Why Should This Be In Core?

Prepares the WMS package for the Java 21 migration. These are safe, mechanical modernizations that improve code readability and remove deprecated patterns without changing runtime behavior.

Benefits

• Eliminates redundant type arguments for cleaner generics
• Uses pattern-matching instanceof (Java 16+) to remove explicit casts
• Converts anonymous SAM class to lambda expression for conciseness
• Replaces StringBuffer with StringBuilder in non-shared local scopes (better performance)
• Removes unnecessary raw-type casts that bypassed generics type safety

Potential Drawbacks

None. All changes are source-level modernizations with identical bytecode semantics. Build verified with JDK 21 (ant -f release-build.xml). No public API changes — field types, method signatures, and class hierarchies are unchanged.

Applicable Issues

Part of the Java 21 migration effort. No public API changes.

---

Build verification: ant -f release-build.xml — ✅ PASSED (JDK 21.0.10)
Public API diff: No method signature, field type, or class hierarchy changes.
Verdict: SHIP — all changes are safe mechanical modernizations.
Flagged for review: None.

Session: https://app.devin.ai/sessions/5e1cb88fc2934791af5a3dcf8fb16c09

Requested by: @jakexcosme

---

Devin Review

Status	Commit
⚪ Not started	—

Run Devin Review

💡 Connect your GitHub account to enable automatic code reviews.

[devin-ai-integration]

Original prompt from Jake

You are a child Devin session for COG-GTM/WorldWindJava Java 21 migration. Authorized to start. Work ONLY on package wms: src/gov/nasa/worldwind/wms/. Branch from origin/devin/java21-foundation into devin/java21-wms. Target PR base develop. Follow package workflow: pre-count SAM/instanceof, conservative Java 21 modernizations, no public API/test/unrelated changes, JDK21 ant -f release-build.xml, public API diff check, PR title "feat: Java 21 modernization — wms", body with before/after counts/rationale/session/verdict/flags. Return structured output.

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR that start with 'DevinAI' or '@devin'.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring