feat: 조회하기 디자인#59
Merged
Merged
Conversation
Contributor
Author
|
@gemini-code-assist review |
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 TanStack Query의 useInfiniteQuery를 도입하여 매칭 히스토리 기능을 구현하고, 검색·필터링·정렬 기능이 포함된 UI 컴포넌트들을 추가했습니다. 리뷰 결과, 빈 데이터 상태에서 더미 데이터가 노출되는 논리적 오류와 하드코딩된 닉네임 및 숫자값에 대한 수정이 필요합니다. 또한 성능 최적화를 위해 반복적인 날짜 객체 생성과 max-height 애니메이션 방식을 개선해야 하며, 컴포넌트 분리 및 웹 접근성 준수(aria-label) 등 코드 품질과 표준을 위한 보완이 권장됩니다.
Contributor
Author
|
@gemini-code-assist review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
매칭 조회 페이지 UI 구현 및 디자인 완성
매칭 상대 카드 컴포넌트 개발 (프로필, 통계, 관심사 표시)
검색, 필터링, 정렬 기능 추가 (닉네임, 나이, 전공, MBTI)
더미 데이터 및 빈 상태 UI 구현
Diagram Walkthrough
flowchart LR A["MatchingListPage<br/>SSR 데이터 프리페칭"] --> B["ScreenMatchingList<br/>메인 화면 레이아웃"] B --> C{"매칭 데이터<br/>존재 여부"} C -->|있음| D["YesMatchingList<br/>검색/필터/정렬"] C -->|없음| E["NoMatchingList<br/>빈 상태 UI"] D --> F["MatchingListCard<br/>카드 컴포넌트"] F --> G["CardHeader<br/>프로필 정보"] F --> H["CardStats<br/>나이/MBTI/연락빈도"] F --> I["CardHobbies<br/>관심사 태그"]File Walkthrough
dummyData.ts
매칭 상대 더미 데이터 세트 생성app/matching-list/_components/dummyData.ts
useMatchingHistory.ts
매칭 파트너 인터페이스 구조 업데이트hooks/useMatchingHistory.ts
birthDatenullable 처리 (string | null)profileImageKey→profileImageUrl필드명 변경hobbies구조 변경 (category, name 객체 배열)intros필드 추가 (question, answer 객체 배열)contactFrequency타입을 string으로 변경tags,song필드 제거MatchingListCard.tsx
매칭 카드 UI 컴포넌트 개발app/matching-list/_components/MatchingListCard.tsx
NoMatchingList.tsx
빈 상태 UI 컴포넌트 구현app/matching-list/_components/NoMatchingList.tsx
ScreenMatchingList.tsx
매칭 조회 페이지 메인 화면 구현app/matching-list/_components/ScreenMatchingList.tsx
YesMatchingList.tsx
검색/필터/정렬 기능 구현app/matching-list/_components/YesMatchingList.tsx
page.tsx
매칭 조회 페이지 라우트 구현app/matching-list/page.tsx
/api/matching/history엔드포인트 호출✨ Describe tool usage guide:
Overview:
The
describetool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.When commenting, to edit configurations related to the describe tool (
pr_descriptionsection), use the following template:With a configuration file, use the following template:
Enabling\disabling automation
meaning the
describetool will run automatically on every PR.the tool will replace every marker of the form
pr_agent:marker_namein the PR description with the relevant content, wheremarker_nameis one of the following:type: the PR type.summary: the PR summary.walkthrough: the PR walkthrough.diagram: the PR sequence diagram (if enabled).Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the
describetool are quite generic: [Bug fix,Tests,Enhancement,Documentation,Other].If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:
Main topic:performance- pr_agent:The main topic of this PR is performanceNew endpoint- pr_agent:A new endpoint was added in this PRSQL query- pr_agent:A new SQL query was added in this PRDockerfile changes- pr_agent:The PR contains changes in the DockerfileThe list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎
For enhanced user experience, the
describetool can add file summaries directly to the "Files changed" tab in the PR page.This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set
pr_description.inline_file_summaryin the configuration file, possible values are:'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.true: A collapsable file comment with changes title and a changes summary for each file in the PR.false(default): File changes walkthrough will be added only to the "Conversation" tab.Utilizing extra instructions
The
describetool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
More PR-Agent commands
See the describe usage page for a comprehensive guide on using this tool.