Skip to content

Conversation

@samumantha
Copy link
Contributor

For some reason the guide linked to some old repository and not the mirror of the actual images currently used in notebooks. Maybe this was forgotten during switch from old to new notebooks version?

@samumantha samumantha requested review from kamirazio and tourunen July 7, 2023 09:56
**Application template** Template provides the base features for your application. Most of the templates are based on
container images maintained by Notebooks team. Take a look at the
[image sources in notebook-images repository](https://github.com/CSCfi/notebook-images/tree/master/builds).
[image sources in notebook-images repository](https://github.com/CSCfi/notebooks-public-images).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should read notebooks-public images as well (like line 25)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 🔨

Copy link
Contributor

@tourunen tourunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joonas-somero joonas-somero merged commit 0342ff8 into master Jul 11, 2023
@joonas-somero joonas-somero deleted the swi_notebooks branch July 11, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants