Fix updater: channel follows the running build (rc→beta, stable→stable) - #35
Merged
Merged
Conversation
…le→stable) The channel defaulted to 'stable', so an rc install checked the stable feed — which doesn't exist yet (only prereleases have shipped) → the update check errored. Derive the DEFAULT channel from this build's own version: a prerelease build (…-rc.N / -beta.N / -alpha.N) tracks beta, a plain X.Y.Z tracks stable (defaultChannelForVersion / isPrereleaseVersion, pure + unit-tested cross-OS). An explicit user choice (the dialog radio, persisted) still overrides. Also: a "no release for this channel" result now reports as up-to-date (isNoReleaseForChannel), not a scary error — so a stable build with no stable release yet says "you're up to date" instead of failing. 4 new node:test cases. Typecheck + build clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updater channel defaulted to `stable`, so an rc install checked the stable feed — which doesn't exist yet (only prereleases have shipped) → the update check errored. This is the "no stable release throws an error" bug.
Fix
Tests
4 new `node:test` cases (rc→beta, stable→stable, garbage-tolerant). Typecheck + build clean.
Note: this ships in the NEXT build; existing rc.8 installs already have the old default baked in, so they may still need one manual update to a build containing this fix.