fix(release): publish to the repo the workflow runs in (directelectron org doesn't exist yet)#6
Merged
Merged
Conversation
…ng directelectron org The v0.1.0 rebuild died with electron-builder GET api.github.com/repos/directelectron/spyde/releases -> 404: the publish block pointed at the planned directelectron org home, which doesn't exist yet (and GITHUB_TOKEN couldn't publish cross-repo even if it did — the whole release.yml draft-first design assumes same-repo). - release.yml passes -c.publish.owner/.repo from the github context, so publishing follows the repo the workflow runs in and survives the future org transfer with zero edits (verified locally: the override merges with --config and lands in the baked app-update.yml) - electron-builder.yml's static owner -> CSSFrancis so a local build's update feed points where releases actually live today
CSSFrancis
added a commit
that referenced
this pull request
Jul 14, 2026
…n-zip) These specs were red on the feat/report-phase1 baseline, independent of the anyplotlib bump: - ipf_perf + movie_export: the backend-error audits tripped on '[spyde RENDERER-ERROR] Failed to create WebGPU Context Provider', a benign warning Chromium emits from the figure iframe whenever the runner has no usable WebGPU adapter (every hosted CI runner under xvfb). anyplotlib falls back to Canvas2D and the render is still correct. Exclude this line in backendErrorLines (_harness.cjs) and in ipf_perf's inline traceback filter — matching the existing pattern for CSP / willReadFrequently / Chromium .cc(line) noise. A real Python traceback is never this renderer line, so real errors still fail the audit (verified against the exact CI log lines). - report_sidebar #6: extracted the .spyde-report with 'tar -xf', but the container is a ZIP (PK magic) — GNU tar on the Linux runner rejects it ('does not look like a tar archive'). Use 'unzip' on Linux/macOS (bsdtar reads zip on Windows, so that branch is unchanged). Verified end-to-end: a real write_report() zip extracts to the expected report.md/figures/ assets/ layout via the exact 'unzip -o -q' command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What killed the v0.1.0 rebuild
electron-builder hit
GET /repos/directelectron/spyde/releases→ 404:electron-builder.yml's publish block points at the planned org home, which doesn't exist yet. (Even when it does, the workflow'sGITHUB_TOKENcan't publish cross-repo —release.yml's draft-first design already assumes same-repo.)Fix
release.ymlpasses-c.publish.owner=${{ github.repository_owner }} -c.publish.repo=${{ github.event.repository.name }}— publishing always targets the repo the workflow runs in, so it works today on CSSFrancis and keeps working unchanged after a transfer todirectelectron.electron-builder.ymlstatic owner →CSSFrancisso local builds'app-update.ymlpoints where releases actually live today.Verified locally (Windows)
Full
npm run distwith-c.publish.owner=OVERRIDETEST -c.publish.repo=overriderepo: build succeeds end-to-end (NSIS installer + blockmap), and the bakedresources/app-update.ymlcontains the override values — the-cdot-notation merges correctly with--config electron-builder.yml. This also re-validates the Windows packaging leg post-PR#3, which no CI run had completed.After merging
I'll retag
v0.1.0on the merge commit (old tag already deleted) and watch the release run.