Better handling of start_time = None and end_time = None#249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
start_time,end_timecan be set toNone#239bypass_validationargument and add to YAML #231To fix #239, the following changes are made:
BoundaryForcingandSurfaceForcingcan still receivestart_time = Noneandend_time = None, however a warning is triggered in that case. This option is now also documented in the docstringsInitialConditionscannot receiveini_time = None, an error will be raised in that caseTo fix #231, the
bypass_validationparameter is now written to YAML and read from YAML.start_time,end_timecan be set toNone#239, closes Documentbypass_validationargument and add to YAML #231pre-commit run --all-filesdocs/releases.mddocs/api.rst