Skip to content

Better handling of start_time = None and end_time = None#249

Merged
NoraLoose merged 5 commits into
CWorthy-ocean:mainfrom
NoraLoose:start-end-time
Feb 19, 2025
Merged

Better handling of start_time = None and end_time = None#249
NoraLoose merged 5 commits into
CWorthy-ocean:mainfrom
NoraLoose:start-end-time

Conversation

@NoraLoose
Copy link
Copy Markdown
Collaborator

@NoraLoose NoraLoose commented Feb 19, 2025

This PR addresses two issues:

To fix #239, the following changes are made:

  • BoundaryForcing and SurfaceForcing can still receive start_time = None and end_time = None, however a warning is triggered in that case. This option is now also documented in the docstrings
  • InitialConditions cannot receive ini_time = None, an error will be raised in that case

To fix #231, the bypass_validation parameter is now written to YAML and read from YAML.

@NoraLoose NoraLoose merged commit d22eb59 into CWorthy-ocean:main Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

start_time , end_time can be set to None Document bypass_validation argument and add to YAML

1 participant