Move conversion to float64 to after choosing subdomain#264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#244 enforced double precision on the source data to ensure reproducibility. However, this led to significant slowdowns when Dask was not used. For example, the example grid in the documentation now takes 2 minutes to generate instead of 7 seconds. This issue arose because the conversion to double precision was applied to the entire source dataset, even when only a subset of the data (in both spatial and temporal dimensions) was needed downstream.
Solution
This pull request moves the conversion to double precision to occur only after selecting the relevant subdomain from the data. As a result, grid generation—and likely all other non-Dask operations—are now much faster again.
pre-commit run --all-filesdocs/releases.md