Fix handling of optional variables in Unified BGC datasets#320
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
Only looked at the .py files, but those look fine to me! |
Collaborator
Author
|
Thanks @ScottEilerman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in
SurfaceForcingand ensures that optional variables inUnifiedBGCDatasetandUnifiedBGCSurfaceDataset(used byInitialConditions,BoundaryForcingandSurfaceForcing) are handled correctly. Specifically, if an optional variable is present in the source data, it is now read from there rather than treated as missing and filled with a default value. This is especially relevant because Pierre has updated his "unified BGC dataset" so that it now includes not only required but also all optional variables (see #313).Changes
Corrected logic to correctly detect and use available optional variables in
SurfaceForcing.Updated external test data to reflect a mix of present and missing optional variables for
UnifiedBGCDatasetandUnifiedBGCSurfaceDataset. The updated external data led to a necessary overwriting of the validation test data.Added tests for
SurfaceForcing,InitialConditions,BoundaryForcingto verify:UnifiedBGCDatasetandUnifiedBGCSurfaceDatasetretain their original (non-constant) values.Updated example notebooks to read from Pierre's extended unified BGC dataset, which now includes all optional variables.
Checklist
pre-commit run --all-filesdocs/releases.mddocs/api.rst