Skip to content

Option to ignore coarse dimensions when partitioning#348

Merged
NoraLoose merged 5 commits into
CWorthy-ocean:mainfrom
NoraLoose:ignore-coarse-dims
Jun 17, 2025
Merged

Option to ignore coarse dimensions when partitioning#348
NoraLoose merged 5 commits into
CWorthy-ocean:mainfrom
NoraLoose:ignore-coarse-dims

Conversation

@NoraLoose
Copy link
Copy Markdown
Collaborator

@NoraLoose NoraLoose commented Jun 16, 2025

This PR adds a parameter include_coarse_dimensions to partition() and partition_netcdf(). If set to False, the dimensions eta_coarse and xi_coarse are ignored during the partitioning process.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@NoraLoose NoraLoose changed the title Option to ignore coarse dimension when partitioning Option to ignore coarse dimensions when partitioning Jun 16, 2025
@NoraLoose NoraLoose requested a review from ScottEilerman June 16, 2025 22:09
Copy link
Copy Markdown
Contributor

@ScottEilerman ScottEilerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The most irrelevant nitpick: this line in the PR description is backwards:

If set to True, the dimensions eta_coarse and xi_coarse are ignored during the partitioning process.

I forget if the PR descriptions get auto-included anywhere but might as well fix it quick, then good to merge!

@NoraLoose
Copy link
Copy Markdown
Collaborator Author

The most irrelevant nitpick: this line in the PR description is backwards:

If set to True, the dimensions eta_coarse and xi_coarse are ignored during the partitioning process.

I forget if the PR descriptions get auto-included anywhere but might as well fix it quick, then good to merge!

Thanks, good catch -- fixed!

@NoraLoose NoraLoose merged commit 115fb56 into CWorthy-ocean:main Jun 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partitioning fails due to divisibility of coarse dimensions

2 participants