Skip to content

Centered gaussian release#413

Merged
NoraLoose merged 7 commits into
mainfrom
gaussian_centered
Aug 22, 2025
Merged

Centered gaussian release#413
NoraLoose merged 7 commits into
mainfrom
gaussian_centered

Conversation

@smaticka
Copy link
Copy Markdown
Contributor

This PR reflects the changes being done in roms related to this isssue: CWorthy-ocean/ucla-roms#31

Previously, the gaussian shape was previously multiplied by the height of each cell, but since the cell heights varied, the larger cells reflected more mass.

By removing the cell height product, the distribution looks more centered around the release location:

image

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.73%. Comparing base (a18c2f0) to head (eb77d2e).
⚠️ Report is 17 commits behind head on main.

@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   92.73%   92.73%   -0.01%     
==========================================
  Files          23       23              
  Lines        5481     5479       -2     
==========================================
- Hits         5083     5081       -2     
  Misses        398      398              
Flag Coverage Δ
unittests 92.73% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
roms_tools/setup/cdr_forcing.py 90.93% <100.00%> (-0.06%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@smaticka
Copy link
Copy Markdown
Contributor Author

Thanks for adding the details to release.md @NoraLoose. I forgot about that pre-commit step. Do you think it's appropriate to add the things to do when contributing? here: https://github.com/CWorthy-ocean/roms-tools?tab=contributing-ov-file

I think this PR is otherwise ready to go.

@NoraLoose NoraLoose merged commit 65ce584 into main Aug 22, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants