Skip to content

GLORYS utility function#445

Closed
NoraLoose wants to merge 40 commits into
CWorthy-ocean:mainfrom
NoraLoose:glorys-utility
Closed

GLORYS utility function#445
NoraLoose wants to merge 40 commits into
CWorthy-ocean:mainfrom
NoraLoose:glorys-utility

Conversation

@NoraLoose
Copy link
Copy Markdown
Collaborator

@NoraLoose NoraLoose commented Aug 28, 2025

This PR introduces a GLORYS utility function and updates dataset documentation.

Key Changes

1. New Utility Function

2. Dataset Documentation Updates (datasets.ipynb)

  • Shows how to download external datasets:
    • GLORYS via copernicusmarine
      • Without the utility function for global datasets
      • With the utility function for regional datasets
    • Unified BGC data from our Google Drive

Internal Refactors

To support the new utility function, the Dataset class was refactored, moving some methods to standalone functions for broader usability:

  • concatenate_longitudes
  • choose_subdomain
  • get_target_coords (now accepts a grid_ds instead of a full grid)

Checklist

@NoraLoose NoraLoose marked this pull request as draft August 28, 2025 22:44
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@NoraLoose NoraLoose marked this pull request as ready for review September 8, 2025 22:35
@NoraLoose NoraLoose mentioned this pull request Sep 9, 2025
@NoraLoose
Copy link
Copy Markdown
Collaborator Author

Closing this because I re-opened the same PR #457 on the main rather than my fork, so that the copernicusmarine credentials actually work via secrets.

@NoraLoose NoraLoose closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Utility function to determine GLORYS download bounds from a ROMS grid

1 participant