Only update child boundary indices if boundary not entirely on land#503
Merged
Conversation
Collaborator
Author
|
@ScottEilerman this is a follow-up to PR #480 |
NoraLoose
changed the title
ScottEilerman
approved these changes
Dec 8, 2025
Contributor
ScottEilerman
left a comment
ScottEilerman
left a comment
There was a problem hiding this comment.
Just now catching up on the conversation on the previous PR... no objections here so feel free to keep things moving whenever you're satisfied!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child boundaries that lie entirely on land cause issues when updating their indices, which previously resulted in a confusing error message (#486). This PR disables this subroutine for such cases.
In addition, this PR fixes several existing tests by correctly wrapping longitudes before evaluation.
docs/releases.md