Change database engine to InnoDB#28
Merged
TheWitness merged 1 commit intoCacti:developfrom Nov 30, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a server migration and database tuning, I noted for the tables that the database engine was MyISAM and so changed it in my import SQL. I noticed the base application has conversion to InnoDB (and is supported in the minimum required database server version for the base application). I wondered if it is preferred and that these should also use it.
This change seems to apply only to a new install. I wonder about a plugin version change to change existing tables. I am not familiar with such and so I would only know to copy logic from another plugin (thold).