Avoid monitor JavaScript redeclaration errors#221
Merged
Conversation
TheWitness
approved these changes
Jul 9, 2026
TheWitness
left a comment
Member
There was a problem hiding this comment.
This bit is interesting. I'm pretty sure I know how it happened. Good job!
Member
|
@somethingwithproof, I think the AI did this one. It's a global either in layout.js or global_session.php. Pretty sure in global_session.php. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates top-level declarations in
js/monitor.jsfromlet/consttovar.The Monitor page can reload content through AJAX. When
monitor.jsis executed more than once, top-levellet/constdeclarations can throw JavaScript redeclaration errors, such as:Uncaught SyntaxError: Identifier 'refreshMSeconds' has already been declaredThis can prevent Monitor dropdowns and filter controls from applying changes correctly after an AJAX reload.
This change keeps block-scoped declarations inside functions unchanged and only adjusts the top-level declarations that may be executed more than once.
Fixes #220
Tested:
refreshMSecondsredeclaration errorgit diff --checkreturns no whitespace errors