Improve performance render many shapes#589
Merged
Merged
Conversation
Member
Author
|
@jmwright This is ready. In my local testing the 400 shape render time was reduced to < 200ms from ~7s. The pytest is a coarse test and will catch only significant drops in performance. Currently there is no status update during render. This could be improved in the future. Perhaps the viewer updates can be changed to not be strictly batched as in this PR. I think updates should be based on timing rather than per shape which is too slow. So viewer updates could be made say every 0.5s or there could be some other indication of progress/status. |
jmwright
approved these changes
Jul 6, 2026
jmwright
left a comment
jmwright
left a comment
Member
There was a problem hiding this comment.
Thanks for this @lorenzncode !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test to measure render and erase time in CI. Locally on GPU I measure >7s.