Skip to content

Extrude with both=True fix #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2020
Merged

Extrude with both=True fix #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d48f02e
combineWithBase fix
adam-urbanczyk Apr 14, 2020
9510c67
Allow to self-fuse a compound
adam-urbanczyk Apr 14, 2020
6710668
Formatting fix
adam-urbanczyk Apr 15, 2020
c131bda
Test if extrude with both=True fuses the solids
adam-urbanczyk Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cadquery/cq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2675,6 +2675,8 @@ def _combineWithBase(self, obj):
r = obj
if baseSolid is not None:
r = baseSolid.fuse(obj)
elif isinstance(obj, Compound):
r = obj.fuse()

return self.newObject([r])

Expand Down
7 changes: 6 additions & 1 deletion cadquery/occ_impl/shapes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,7 +1997,12 @@ def fuse(self, *toFuse):
fuse_op = BRepAlgoAPI_Fuse()
# fuse_op.SetFuzzyValue(TOLERANCE)

rv = self._bool_op(self, toFuse, fuse_op)
args = tuple(self) + toFuse

if len(args) <= 1:
rv = self
else:
rv = self._bool_op(args[:1], args[1:], fuse_op)

# fuse_op.RefineEdges()
# fuse_op.FuseEdges()
Expand Down
2 changes: 2 additions & 0 deletions tests/test_cadquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2548,6 +2548,8 @@ def testExtrude(self):
# extrude symmetrically
s = Workplane("XY").circle(r).extrude(h, both=True)

self.assertTrue(len(s.val().Solids()) == 1)

top_face = s.faces(">Z")
bottom_face = s.faces("<Z")

Expand Down