Sodium on NeoForge does not check the game version before trying to load

[burningtnt]

Bug Description

If user installs Sodium for NeoForge, Minecraft 1.21.11 on NeoForge, Minecraft 26.1.1, Sodium incorrectly blame the launcher for updating LWJGL's version.

Sodium should validate whether game version matches with the Sodium's expected one first.

Reproduction Steps

• Install NeoForge and Minecraft 26.1.1.
• Install Sodium for NeoForge, Minecraft 1.21.11
• Launch the game.

Log File

Some sensible information are hidden for protecting users's privacy.

[08:45:25] [main/INFO]: JVM Uptime at startup: 712ms
[08:45:26] [main/INFO]: Starting FancyModLoader version 11.0.13 (CLIENT in PROD)
[08:45:26] [main/INFO]: Game directory: D:\PYL\Projects\HMCL Usage\versions\26.1.2-NeoForge
[08:45:27] [main/INFO]: Found 3 early service jars (out of 103) in 178ms
[08:45:27] [main/INFO]: Loading FML Early Services:
[08:45:27] [main/INFO]:  - mods/sodium-neoforge-0.8.12-beta.1+mc1.21.11.jar
[08:45:27] [main/INFO]:  - [PRIVATE]/libraries/net/neoforged/fancymodloader/earlydisplay/11.0.13/earlydisplay-11.0.13.jar
[08:45:27] [main/INFO]:  - [PRIVATE]/libraries/net/neoforged/fancymodloader/loader/11.0.13/loader-11.0.13.jar
[08:45:27] [main/INFO]: Running graphics bootstrap plugin sodium
[08:45:27] [main/INFO]: Problematic LWJGL version source: /[PRIVATE]/libraries/org/lwjgl/lwjgl/3.4.1/lwjgl-3.4.1.jar
[08:45:27] [main/ERROR]: The game failed to start because the currently active LWJGL version is not compatible.

Installed version: 3.4.1+2
Required version: 3.3.3

You seem to be using HMCL. This issue is likely caused by HMCL.

You must change the LWJGL version in your launcher to continue. This is usually controlled by the settings for a profile or instance in your launcher.

If you need assistance fixing the LWJGL version, you should contact HMCL, not Sodium.

For more information, please see: https://link.caffeinemc.net/help/sodium/runtime-issue/lwjgl3/gh-2561
[08:45:27] [main/INFO]: Closing FML Loader 66971f6b
[08:45:27] [main/INFO]: Clearing ModLoader

[jellysquid3]

Why do you believe this is incorrect? Minecraft 1.21.11 specifies in the version manifest that LWJGL 3.3.3 should be used, and it is clearly shown that Minecraft is launching with the wrong version:

[08:45:27] [main/INFO]: Problematic LWJGL version source: /[PRIVATE]/libraries/org/lwjgl/lwjgl/3.4.1/lwjgl-3.4.1.jar

The launcher is responsible for downloading and configuring these libraries.

[burningtnt]

Have you EVER read this issue closely?

Install NeoForge and Minecraft 26.1.1.
Install Sodium for NeoForge, Minecraft 1.21.11

Apparently, I'm launching Minecraft 26.1.2 with Sodium for 1.21.11, whose manifest requires LWJGL 3.4.1.

LOL

[jellysquid3]

Your log file says that you are using a version of Sodium for Minecraft 1.21.11.

[08:45:27] [main/INFO]: Loading FML Early Services:
[08:45:27] [main/INFO]:  - mods/sodium-neoforge-0.8.12-beta.1+mc1.21.11.jar

[burningtnt]

Your log file says that you are using a version of Sodium for Minecraft 1.21.11.

[08:45:27] [main/INFO]: Loading FML Early Services:
[08:45:27] [main/INFO]:  - mods/sodium-neoforge-0.8.12-beta.1+mc1.21.11.jar

Have you EVER read this issue closely?

If user installs Sodium for NeoForge, Minecraft 1.21.11 on NeoForge, Minecraft 26.1.1, Sodium incorrectly blame the launcher for updating LWJGL's version.

Sodium should validate whether game version matches with the Sodium's expected one first.

We are talking about the error message displayed where a stuid user installs an incorrect Sodium's version.
Sodium should validate whether game version matches with the Sodium's expected one first, instead of blame the launcher for updating LWJGL's version, since Minecraft itself is who updates LWJGL.

[jellysquid3]

OK, that is my bad for not understanding the root issue. But please be less passive aggressive in the future, it's really not productive.

[jellysquid3]

NeoForge doesn't provide any way to specify version constraints on service plugins, which is the root of the issue here. The actual mod is contained within a nested JAR file, which is added to the mod loader's search paths by our plugin.

Why the service plugin exists is a bit of ugly story with NeoForge, but we have to architect it this way so our code can run before the loading progress window appears.

[jellysquid3]

Probably that means we need to write code in the early service plugin to perform the version check ourselves, but the Minecraft classpath is not even available to us at this point, and I don't know if NeoForge provides any APIs for querying the game version.