Minor fixes to CakePB - #1477
Merged
Merged
Conversation
A redundancy subgoal with no explicit subproof is discharged by a syntactic implication check. That check is directional, so orient it the way VeriPB does: a proof VeriPB accepts without a subproof is accepted here too. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
tanyongkiam
marked this pull request as draft
August 31, 2026 01:17
Contributor
Author
|
I'll add a few more cleanup changes on this branch. |
The pseudo-boolean CNF and WCNF encoders now take their clause syntax, semantics and DIMACS parser from examples/cnf, and no longer depend on the LPR checker or satSem. Each clause is canonicalised before it is encoded, so a repeated literal contributes a single term. The plain-DIMACS parser and printer move out of the LRUP directory into their own theory. The CakeML frontends move alongside the encoders they serve, into cnf_encoding/array. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The CakeML frontends for the clique, colour, MCIS, MCCIS and subgraph isomorphism encoders move alongside the encoders they serve, together with the shared graph-format parser. examples/pseudo_bool/array is left to the pseudo-boolean checker itself. The scripts are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Both carried their own copy of the printer for normalised constraints. They now use a single one, kept alongside the other OPB surface-syntax definitions. It prints a negative bound as -1 rather than ~1, matching the printers already there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
tanyongkiam
marked this pull request as ready for review
August 31, 2026 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.